Masking policy does not apply for models or snapshots about dbt-snow-mask HOT 4 OPEN

access denied to create a PR for you all but apply_masking_policy_list_for_models.sql just needs a for loop after line 5 to fix the issue. Right now it's not looping through the nodes if operation_type = "apply".

{% macro apply_masking_policy_list_for_models(meta_key,operation_type="apply") %}

{% if execute %}

    {% if operation_type == "apply" %}

        {% for model in graph.nodes.values() %}
    
            {% set model_id = model.unique_id | string %}

from dbt-snow-mask.

Hello @melissa-ellevation ,

• Can you please see if you can fork the repo, then it should give access to create PR ?
• Please make sure to attach the tests for the components which changed and everything else
• The repo already has some integration tests configured for contributors, Please see https://github.com/entechlog/dbt-snow-mask#how-to-do-an-integration-test- for more details

from dbt-snow-mask.

Hello @melissa-ellevation , Now I think more about it, this was by design. Idea was not to apply the masking policies globally by calling the apply command, rather apply them when the dbt run for the model happens. Does this make sense ? Happy to discuss more about this and see if this is still a valid bug/PR

from dbt-snow-mask.

@entechlog WOW ok thank you for your patience with this, I figured out why this wasn't working for me. I had "{{dbt_snow_mask.create_masking_policy('models')}}" running in on-run-end instead of as a post-hook to models and snapshots specifically.

I just updated the PR to include a note in the README, but this issue and PR can be closed whether or not you choose to add the note.

Didn't work:

on-run-start:
  
- "{{ dbt_snow_mask.create_masking_policy('sources')}}"
  
- "{{ dbt_snow_mask.create_masking_policy('models')}}"


on-run-end:
  
- "{{ dbt_snow_mask.apply_masking_policy('sources')}}"
  
- "{{ dbt_snow_mask.apply_masking_policy('models') }}"

Worked:

on-run-start:
  
- "{{ dbt_snow_mask.create_masking_policy('sources')}}"
  
on-run-end:
  
- "{{ dbt_snow_mask.apply_masking_policy('sources')}}"
  

models:
  
pre-hook:
   
 - "{{ dbt_snow_mask.create_masking_policy('models')}}"
  
post-hook:
    
 - "{{ dbt_snow_mask.apply_masking_policy('models') }}"

Thank you for your help and I'm sorry for the confusion!

from dbt-snow-mask.