Code Monkey home page Code Monkey logo

Comments (12)

enkore avatar enkore commented on August 18, 2024

Would it suffice to sign the release tag(s)?

from j4-dmenu-desktop.

cinemast avatar cinemast commented on August 18, 2024

No. Please sign the .tar.gz tarballs. At least the latest one and for future releases.

from j4-dmenu-desktop.

enkore avatar enkore commented on August 18, 2024

I created a signature for the tarball (at least, I think I did that, never sure with GPG what I actually do... *) ; let's hope GitHubs .tar.gz creation is deterministic...

* for future reference so I don't forget how this is done:

  1. Fetch .tar.gz from GH
  2. Extract
  3. diff extracted tarball and local repo
  4. gpg --output rxxxx.tar.gz.sig --detach-sign rxxxxx.tar.gz with key 9B8450B91D1362C1 / 1D1362C1
  5. Upload .sig to GH

from j4-dmenu-desktop.

zopieux avatar zopieux commented on August 18, 2024

Please be aware that Github fails at creating tarballs for big projects. I've seen it fail for Raspberry Linux kernel (300MB). I won't rely on that anymore, even for smaller projects. But I guess it is safe for a few-kb project like j4-demu-desktop.

from j4-dmenu-desktop.

cinemast avatar cinemast commented on August 18, 2024

For my projects it is working pretty fine. And a lot of projects use it. So maybe for big tarballs it is not working. But I guess that is not an issue for this project.

from j4-dmenu-desktop.

cinemast avatar cinemast commented on August 18, 2024

Can you make a sense of why this testcase is failing?

1/1 Test #1: j4-dmenu-tests ...................***Failed    0.00 sec
/tmp/buildd/j4-dmenu-desktop-2.12/obj-x86_64-linux-gnu/some-file-that-doesnt-exist: No such file or directory
1234 --caption "Regression Test 18"

j4-dmenu-tests is a Catch v1.0 b10 host application.
Run with -? for options


SearchPath/XDG_DATA_HOME

/tmp/buildd/j4-dmenu-desktop-2.12/src/TestSearchPath.cc:12


/tmp/buildd/j4-dmenu-desktop-2.12/src/TestSearchPath.cc:20: FAILED:
  REQUIRE( result.size() == 1 )
with expansion:
  0 == 1

===============================================================================
19 test cases - 1 failed (53 assertions - 1 failed)

from j4-dmenu-desktop.

enkore avatar enkore commented on August 18, 2024

Works for me... also http://golem.enkore.de/job/j4-dmenu-desktop-dev/20/console

from j4-dmenu-desktop.

cinemast avatar cinemast commented on August 18, 2024

Hm.. strange. Is there maybe an undocumented dependency, like having an X-Server installed and running or something like that? What is this test supposed to check?

from j4-dmenu-desktop.

cinemast avatar cinemast commented on August 18, 2024

I think it fails when there is no /usr/share/applications folder on the system.

from j4-dmenu-desktop.

justin8 avatar justin8 commented on August 18, 2024

That folder should be created by one of your base system packages. I'm not too familiar with the Debian packaging standards but arch/fedora/rhel all have that with a basic desktop environment. You might have to depend on whatever provides it for the deb.

from j4-dmenu-desktop.

cinemast avatar cinemast commented on August 18, 2024

I patched out this specific testcase. The package got uploaded into Debian. Now it is up to the ftp-masters when it will be in official repos.

https://ftp-master.debian.org/new/j4-dmenu-desktop_2.12-1.html

Thank you for your support.

from j4-dmenu-desktop.

cinemast avatar cinemast commented on August 18, 2024

Your software officially arrived at debian :)

https://packages.debian.org/sid/j4-dmenu-desktop

from j4-dmenu-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.