Comments (5)
One alternative long term solution might be build all the system libraries from source via bazel rules. I know @walkingeyerobot has been thinking about this for a while now, but I'm not sure how close it is.
from emsdk.
I am not necessarily against that approach but that would take a bit of time, right? From (thin) LTO, PIC, and 64-bit, we have 16 (?) possible combinations multiplied by around 40 different ports/libraries? That's 640 jobs based on my estimates...
from emsdk.
I am not necessarily against that approach but that would take a bit of time, right? From (thin) LTO, PIC, and 64-bit, we have 16 (?) possible combinations multiplied by around 40 different ports/libraries? That's 640 jobs based on my estimates...
The idea is that those system libraries would be just like any other sources in your project so only the precise config that you need to for a given build would be produced. There would be no need to enumerate them or build all of them ever.
from emsdk.
I am fine with this change in general. I'm too far from getting runtimes on demand to work with bazel, and if you have the bandwidth and motivation to contribute this, I'm happy to accept it.
However, I don't think we can make use of bash in genrules. The bazel toolchain works on linux, mac, and windows, and while the bash that you have will work great on linux, bash on mac has some odd quirks and on windows it simply doesn't exist. If you can write this in something more portable (i.e. python) then I think that'll be fine.
Also, this is complex enough that I would ask for a smoketest to be written for CI for all three supported platforms.
from emsdk.
I am fine with this change in general. I'm too far from getting runtimes on demand to work with bazel, and if you have the bandwidth and motivation to contribute this, I'm happy to accept it.
However, I don't think we can make use of bash in genrules. The bazel toolchain works on linux, mac, and windows, and while the bash that you have will work great on linux, bash on mac has some odd quirks and on windows it simply doesn't exist. If you can write this in something more portable (i.e. python) then I think that'll be fine.
Also, this is complex enough that I would ask for a smoketest to be written for CI for all three supported platforms.
I think it can be easily wrapped into a Python script, after all, it is mostly just running embuilder.py anyway.
from emsdk.
Related Issues (20)
- emsdk activate breaks things HOT 1
- errors while running emmake make HOT 1
- Version of `wasm_cc_binary` that doesn't untar the result? HOT 4
- set -sMAXIMUM_MEMORY = 4GB & use uuid HOT 1
- [Bazel] [Potential solution] Cannot build multiple emscripten binaries in parallel with bazel HOT 1
- [Bazel] Add example of extracting Emscripten's output with rules_foreign_cc
- emsdk install tot command fails HOT 2
- 3.1.61 Docker image not published HOT 1
- The compilation speed is too slow. HOT 1
- [Bazel] Should the toolchain set the same variables as tools/building.py? HOT 2
- TypeError: Failed to execute 'createObjectURL' on 'URL': Overload resolution failed. HOT 1
- [Bazel] Main bootstrap script for Wasm Audio Worklets not generated HOT 3
- [Bazel] feature flags for the Emscripten toolchain HOT 18
- Downloading files with urllib results in missing KB HOT 3
- THYDU𝕏
- THYDU𝕏
- THYDU𝕏
- [bazel] [rules_foreign_cc] ModuleNotFoundError: No module named 'tools' HOT 11
- wasm_cc_binary with tensorflow lite minimal example failed HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emsdk.