Code Monkey home page Code Monkey logo

Comments (3)

emqplus avatar emqplus commented on July 18, 2024

Reason:

The client was closing its connection immediately after opening with the SO_LINGER option
enabled, and a timeout of 0 seconds. This resulted in a RST with no FIN.
So, even if I called peername immediately after accept, with option
{exit_on_close, false} set, it always returned enotconn.

from esockd.

emqplus avatar emqplus commented on July 18, 2024
diff --git a/src/esockd_connection_sup.erl b/src/esockd_connection_sup.erl
index 7ac155d..9ec37bf 100644
--- a/src/esockd_connection_sup.erl
+++ b/src/esockd_connection_sup.erl
@@ -140,22 +140,26 @@ handle_call({start_connection, _SockArgs}, _From, State = #state{curr_cli

 handle_call({start_connection, SockArgs = {_, Sock, _SockFun}}, _From,
             State = #state{mfargs = MFArgs, curr_clients = Count, access_rules = Rules}) ->
-    {ok, {Addr, _Port}} = inet:peername(Sock),
-    case allowed(Addr, Rules) of
-        true ->
-            case catch esockd_connection:start_link(SockArgs, MFArgs) of
-                {ok, Pid} when is_pid(Pid) ->
-                    put(Pid, true),
-                    {reply, {ok, Pid}, State#state{curr_clients = Count+1}};
-                ignore ->
-                    {reply, ignore, State};
-                {error, Reason} ->
-                    {reply, {error, Reason}, State};
-                What ->
-                    {reply, {error, What}, State}
-    case inet:peername(Sock) of
-        {ok, {Addr, _Port}} ->
-            case allowed(Addr, Rules) of
-                true ->
-                    case catch esockd_connection:start_link(SockArgs, MFArgs) of
-                        {ok, Pid} when is_pid(Pid) ->
-                            put(Pid, true),
-                            {reply, {ok, Pid}, State#state{curr_clients = Count+1}};
-                        ignore ->
-                            {reply, ignore, State};
-                        {error, Reason} ->
-                            {reply, {error, Reason}, State};
-                        What ->
-                            {reply, {error, What}, State}
-                    end;
-                false ->
-                    {reply, {error, fobidden}, State}
           end;
-        false ->
-            {reply, {error, fobidden}, State}
-        {error, Reason} ->
-            {reply, {error, Reason}, State}
   end;

from esockd.

larrymeng avatar larrymeng commented on July 18, 2024

from esockd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.