Comments (4)
hi, thank you for the feedback! In this case I'm not sure the idea with two generics is actually a progress. One thing is that in that concrete case with the JSX, I think this would work:
const content = results.match({
None: () => <Loader />,
Some: movies => <>{movies.map(movie => <MoviesListItem key={movie.id} {...movie} />)}</>
})
the other thing is that I think you can achieve what you want already with the current API. In the end if you want to return an or type with both options, you can just force typescript to use the or type, and it'll work already today, which means this would work:
const content = results.match<JSX.Element|JSX.Element[]>({
None: () => <Loader />,
Some: movies => movies.map(movie => <MoviesListItem key={movie.id} {...movie} />)
})
But, granted, in that case you get no inference for free.
Still, for now I think the way prelude does it for now is probably the right way. The way match
works follows a general principle in functional programming, it's a catamorphism, and that has proven useful in many contexts and libraries, for instance:
and maybe others for sure. If you check these links, they all use one generic only for the return type, so I think that's the better way. But I'm always interested if you have a concrete example or if the "workarounds" i gave are not good enough! By default though, because the concept of catamorphism is so accepted in functional programming, I probably wouldn't touch match
, but we can add another function for some special use-case, and either rename the current match
and have the new function named match
. But currently I think the current setup found in prelude is OK.
Thank you again for the feedback, and let me know what you think!
from prelude-ts.
Oh yeah, I'm definitely fine with it staying like that.
I also found out you can use
results.match<React.ReactNode>({
...
})
from prelude-ts.
I'll make a pull request if that's ok
from prelude-ts.
great to hear you found a good way!
from prelude-ts.
Related Issues (20)
- Replace sed with TS program HOT 3
- Feat request: .ap (apply) on ADTs HOT 9
- make allMatch a type guard as it will be in TS4.0
- add Seq or Vector rotateLeft & rotateRight
- HashMaps comparison always seems to return the same hash code HOT 5
- constant HOT 1
- Allow equality comparer in the Set/Map constructor HOT 3
- Help with preserving order in HashSet HOT 6
- Vite util.inspect HOT 2
- Allow fold to use a different type on the accumulator HOT 3
- Implement sequenceAcc for Option HOT 2
- Tuple2 equality is broken HOT 1
- Make preludeTsContractViolationCb throw an exception instead of a string? HOT 3
- Can areEqual be undefined-safe too? HOT 2
- Validation - accumulating errors with Either HOT 2
- Typo in the docs HOT 1
- Function returned from Either::liftApAcc closes over leftErrs from the outer scope
- HashMap equality calculated incorrectly HOT 14
- Option equality broken HOT 2
- Cannot stringify arbitrary non-POJOs Some. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prelude-ts.