Support clojure.test via custom eval about lein-cljsbuild HOT 6 CLOSED

I've looked at this a little bit, and I'm not sure that I like the way Clojurescript One handles this. To me, the better solution would be to port the clojure.test library to clojurescript, and to write the crossover tests using the subset of clojure.test supported by both languages. As it stands, the Clojurescript One tests are a heavy mixture of Clojure and Clojurescript code, which is ugly, and would probably be a major turn-off for those people who plan to write 100% Clojurescript applications.

from lein-cljsbuild.

I agree with that, and I noticed your approach in supporting tests using assert is a good middle ground. Probably a portable version of clojure.test macros using assert would be useful. I am personally experimenting with assert – it appears something like the following in the ns macro in test files might be required:

(:use;*CLJSBUILD-REMOVE*;-macros
    [cljsbuild.test.macros;*CLJSBUILD-REMOVE*;-cljs
     :only [deftest is is-thrown testing]])

from lein-cljsbuild.

Hmm, your example makes sense to me; the macros would definitely have to be imported differently for CLJ/CLJS. I think the CLJSBUILD-REMOVE feature would in fact work, but it's pretty ugly. I'm noodling around on other possibilities at the moment for how to accomplish that in a nicer way, but I don't have any great ideas so far.

from lein-cljsbuild.

I made some progress running regular clojure.test tests in both Clojure and ClojureScript using the assert technique shown in the cljsbuild examples. The form (is (= ...)) works fine, but (is (thrown-wih-msg? ...)) has some problem still, mainly due to regex match (project-specific issue). It's difficult to trace the error when tests fail, but it's a good start.

https://github.com/kumarshantanu/basil (master, lein jst cljsbuild test)

from lein-cljsbuild.

I've factored out this idea (in a working form) into this library: https://github.com/kumarshantanu/clip-test

from lein-cljsbuild.

That's awesome. I'm going to close this case as it seems like you've taken care of it!

from lein-cljsbuild.