broken fswatch-run symlink installed if using DESTDIR=... about fswatch HOT 4 CLOSED

Hi @ryandesign,

I don't understand what "incorrectly points into the destdir" means. Maybe I can't understand the problem yet, but where else should it point to?

If you stage an installation using DESTDIR, you want it to be jailed into DESTDIR. This is the result of an installation using DESTDIR=/temp (being /temp a placeholder):

/temp/usr
/temp/usr/local
/temp/usr/local/bin
/temp/usr/local/bin/fswatch
/temp/usr/local/bin/fswatch-run
/temp/usr/local/bin/fswatch-run-bash
/temp/usr/local/bin/fswatch-run-zsh

Checking the fswatch-run symlink (and trimming ls long details):

$ cd /temp/usr/local/bin
$ ls -la fswatch*
fswatch
fswatch-run -> /temp/usr/local/bin/fswatch-run-zsh
fswatch-run-bash
fswatch-run-zsh

fswatch-run points to the corresponding script into the directory hierarchy rooted at DESTDIR and this is the intended behaviour.

Could you elaborate on your question, please?

from fswatch.

Hi @ryandesign,

The patch you applied breaks DESTDIR installs:

$ pwd
/temp/usr/local/bin
$ ls -al
fswatch
fswatch-run -> /usr/local/bin/fswatch-run-zsh

while it should link to the script in /temp/usr/local/bin/fswatch-run-zsh.

I don't understand MacPorts behaviour (in Homebrew, it works correctly for example), but dropping DESTDIR is not the solution.

I'll ask somebody at MacPorts to have a look at that one.

Cheers,
-- Enrico

from fswatch.

@emcrisostomo, there is nothing wrong with MacPorts’ behavior. The problem is that you are using DESTDIR where you ought to be using prefix.

The DESTDIR variable is used to facilitate staged installs, where the install target places the build products into a temporary location rather than the final one. For instance, MacPorts installs software to a “destroot” before finally moving it into our “prefix”.

What you’re looking to do is change the root of your installation tree. You must use the prefix variable for this.

from fswatch.

Thank you @larryv,

Doh, that's was clarifying indeed! I'll update Makefile.am.

Thank you very much.

from fswatch.