Is Rails dependency really necessary? about grape-jsonapi HOT 6 CLOSED

Hi @spijet, thanks for your issue. The formatter does use ActiveModel naming and serialization related methods, but only if the object to be serialized actually responds to these methods.

I'm working on a PR to actually remove Rails as a dependency : #12, feel free to check it out and confirm me if it works. Just as well, I am open to suggestions for improvement.

Thanks!

from grape-jsonapi.

Thanks a lot! I'll check this new branch locally in my app and will let you know if it works. I'll add comments (or even commits, maybe 😉) in the PR if anything comes up.

Can you hold this issue as open while I test the PR, please?

from grape-jsonapi.

@spijet PR merged and gem published to rubygems

from grape-jsonapi.

require 'rails' does not prevent library to be used with Sinatra-based apps tbc, but unnecessary dependency is unnecessary dependency.

from grape-jsonapi.

Actually, I just tried to comment out the require 'rails' line by hand and it seems to work fine. Haven't checked all the features yet, though. But still, this won't do in a production environment, where gems are pulled in on every deployment.

from grape-jsonapi.

It seems that I was (kinda) mistaken, and the Formatter module uses some ActiveRecord-specific stuff when working with collections, so it may be better to depend on ActiveRecord instead of Rails, unless I miss something else. :)

from grape-jsonapi.