Fix shell scripts according to ShellCheck's recommendations about embox HOT 6 CLOSED

@wawuwo Hi

I would like to make a contribution and I am willing to fix such issues for all shell scripts from said folder. Hence I wanted to ask if this kind of contribution will be of any value for the project?

Yes, sure.

from embox.

Sorry for the late reply, I saw your answer and since then I've been fixing the scripts in a forked repository.

I wanted to ask if there is a way to check that I haven't broken something accidentally? If there are typical usage scenarios I could check them myself. (I am striving to be careful but you never know until you check)

I found this git rebase upstream/master -i --exec make in contributing guide, is it still relevant?

from embox.

Sorry for the late reply

No problem!

I wanted to ask if there is a way to check that I haven't broken something accidentally? If there are typical usage scenarios I could check them myself. (I am striving to be careful but you never know until you check)

Unfortunataly for full checking you need apropriate boards. I have a couple of such boards. so let me check them when you create PR. I'll try to do it next week.

I found this git rebase upstream/master -i --exec make in contributing guide, is it still relevant?

Yes rebasing is actual (although '--exec make' looks wierd). Howeve you should do rebasing under upstream/master after your PR will be approved/

from embox.

@anton-bondarev I've finished and ready to open a pull request. But I can't decide if I should squash commits into more larger groups before PR. I intentionally made them as atomic as it reasonably possible to ease bisecting in case of any problems and ended up with 33 commits, mostly one commit per file… Would it be better if I squash them or it's OK to have 33 of them?

from embox.

@wawuwo

I've finished and ready to open a pull request.

Great. Do it!:)
You can make PR as is,and after aproving you will squash to one or several commits

from embox.

Closed by
#2847
#2857
#2863
#2876
#2878
#2879
#2880
#2882
#2884
#2885
#2887
#2888

from embox.