Comments (5)
There was a reason that I didn't do this via the ES6 getter/setter syntax, but I can't recall exactly why. I'll reinvestigate to see what the issue was.
I added a test that allows usage of Ember's setter/getter CP's: https://github.com/rwjblue/ember-computed-decorators/blob/master/tests/unit/computed-test.js#L85-L122, but marked it as skip
because babel does not currently allow decorating non-functions. I am waiting on confirmation from @wycats before opening an issue for it with the babel folks.
from ember-decorators.
@rwjblue Does it make sense to apply this decorators to ES5 getter/setter functions?
Example:
let obj = {
first: 'rob',
last: 'jackson',
/* jshint ignore:start */
@computed('first', 'last')
/* jshint ignore:end */
get name() {
},
set name(value, first, last) {
}
};
from ember-decorators.
@cibernox - As I mentioned above, it doesn't work but I can't recall why (I do remember trying). I'll play with it more tonight.
Also, that commented out test uses something like:
let obj = {
first: 'rob',
last: 'jackson',
@computed('first', 'last')
name: {
set() { },
get() { }
}
};
But babel is getting confused with decorators on non-functions.
from ember-decorators.
I am crazy, @stefanpenner implemented get/set in #8.
from ember-decorators.
What do you think?
we will support this eventually, its an ember thing we want to improve. Now that we are dropping IE8 support for 2.0 we can actually start using real get/sets :)
from ember-decorators.
Related Issues (20)
- v5.2 MS Edge 18: Object doesn't support property or method 'apply' HOT 19
- @service router is undefined HOT 8
- Mixin pattern for polymorphic relationships doesn't seem to work with native classes HOT 1
- @service decorator fails on older browsers like IE11, Chrome 41 (Googlebot) HOT 8
- Polyfills for Symbol, Array.find are required to run on older browsers like IE11
- `@sort` deprecation message missing replacement code HOT 3
- TypeError: Ember._setComputedDecorator is not a function HOT 7
- ember-data decorators HOT 2
- ember-typescript-cli v2 HOT 6
- Question: why is @ember-decorators/babel-transforms still referenced in v6? HOT 2
- attribute component decorator receiving array instead of string HOT 2
- `@service` decorator doesn't work with ember 3.10.0 HOT 9
- `@layout` decorator doesn't work in ember addon HOT 5
- 5.1.4 / 5.2.0 not compatible with iOS 9.3.5 HOT 3
- Recommend usage of `ember-cli-dependency-lint`
- Detect when incompatible versions of `ember-decorators` are clobbering one another
- Add @classNameBindings and @attributeBindings class decorators HOT 2
- 6.1.0: @classNameBindings and @attributeBindings
- Build error: Generic type 'AttrOptions<T>' requires 1 type argument(s).
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-decorators.