Code Monkey home page Code Monkey logo

Comments (6)

rwjblue avatar rwjblue commented on June 4, 2024

I agree with your expected output. This issue is for tracking the prettier fix, right?

from ember-angle-brackets-codemod.

GavinJoyce avatar GavinJoyce commented on June 4, 2024

Yes, I'm working on a fix there. I opened an issue here mostly for discoverability

from ember-angle-brackets-codemod.

mfeckie avatar mfeckie commented on June 4, 2024

In a similar vein, prettier also does some breaking things to nested if/else scenarios. prettier/prettier#5340 (comment)

Would be nice to be able to skip prettier in the codemod and leave to the user to reformat as necessary / desired

from ember-angle-brackets-codemod.

GavinJoyce avatar GavinJoyce commented on June 4, 2024

For speed and so that I can experiment easily, I'm working on a fork of prettier here which I'm running in conjunction with this codemod over Intercom's codebase:

GavinJoyce/prettier#1

I'm hoping that this will enable me to:

  • Quickly and incrementally codemod our large codebase to angle bracket invocation
  • Merge most of the changes back into prettier

from ember-angle-brackets-codemod.

lolmaus avatar lolmaus commented on June 4, 2024

More cases of this bug are described in #95 (duplicate of subj).

from ember-angle-brackets-codemod.

Turbo87 avatar Turbo87 commented on June 4, 2024

resolved by #97

from ember-angle-brackets-codemod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.