What should we do if code-modding components that contain positional params? about ember-angle-brackets-codemod HOT 8 CLOSED

One strategy I've taken before for ambiguous code which couldn't be accurately code-modded correctly was to add a comment outlining the problem to bring it to people's attention.

These comments might get lost in a sea of other changes in the resultant diff. Perhaps we could emit a log file or console messages instead?

from ember-angle-brackets-codemod.

@GavinJoyce @tylerturdenpants We could follow a similar pattern to ember-modules-codemod which wrote a log file if it discovered unknown modules during the transform

from ember-angle-brackets-codemod.

@patocallaghan Is this off of master or the latest release?

from ember-angle-brackets-codemod.

@tylerturdenpants This is on latest master. I've a failing test here https://github.com/rajasegar/ember-angle-brackets-codemod/pull/37

from ember-angle-brackets-codemod.

@tylerturdenpants I'm just getting to grips with Angle Bracket syntax and this looks like it's somewhat expected. Angle Bracket components don't support positional params and should instead be keyed properties

See this discuss answer https://discuss.emberjs.com/t/how-to-use-positionalparams-with-angle-bracket-invocation/15739

// EXPECTED
<VerticalCollection @items=items @tagName="ul" @estimateHeight="50" as |item i|>
...
</VerticalCollection>

// or
<VerticalCollection @params={{array items}} @tagName="ul" @estimateHeight="50" as |item i|>
...
</VerticalCollection>

I'm not entirely sure what we should do here as we'll never know the correct key value, and I don't think the {{array}} helper can be assumed to be installed.

One strategy I've taken before for ambiguous code which couldn't be accurately code-modded correctly was to add a comment outlining the problem to bring it to people's attention.

from ember-angle-brackets-codemod.

The fact that this has tripped me up while working on the codemod makes me feel like this is a really good idea. The only downside would be the clutter we could unnecessarily cause as a result. Maybe just a console message instead?

@rajasegar @GavinJoyce @rwjblue what do you think?

from ember-angle-brackets-codemod.

As a first step, here's a PR which skips and emits a simple console warning: https://github.com/rajasegar/ember-angle-brackets-codemod/pull/42

I think we should improve the warning feedback though, it's easy to miss at the moment:

from ember-angle-brackets-codemod.

I think the fix in https://github.com/rajasegar/ember-angle-brackets-codemod/pull/42 is sufficient. There is basically no way for us to know what to refactor this into. For certain built-in components like link-to it's okay to build special handling code, but I don't think it's worth the time to attempt that for every addon component like that that we encounter 😅

from ember-angle-brackets-codemod.