Comments (9)
cc @Turbo87 ☝️
from eslint-plugin-ember.
You can already do this with ESLint with this rule:
'no-shadow': ['error', { 'builtinGlobals': true }]
from eslint-plugin-ember.
Oh, true @t-sauer. Then I think we should add this to recommended config.
from eslint-plugin-ember.
Then I think we should add this to recommended config.
that would require a breaking change release again and I'm very much against that in the foreseeable future. IMHO we should only do breaking change releases if we actually need to break how a rule behaves, the recommended config should ideally live outside of this repo/project.
from eslint-plugin-ember.
@t-sauer the potential advantage of having a custom rule would be that it can be --fix
-able, but it's probably not worth it in this case 🤔
from eslint-plugin-ember.
I found that there was a similar suggestion made to the Airbnb eslint base and it was not merged, with this as the reasoning: airbnb/javascript#667 (comment)
So similarly, I don't think we should be including the builtinGlobals
option in our configuration.
from eslint-plugin-ember.
I think that having a dedicated fixable rule just for the ember object, string, etc. might be a good idea, I'd personally find it valuable.
from eslint-plugin-ember.
Ok, so it looks like indeed having a dedicated rule will be most valuable in this case.
from eslint-plugin-ember.
Picking this up then - will probably make a PR around saturday/sunday
from eslint-plugin-ember.
Related Issues (20)
- New rule to lint against referencing `let` variables in `<template>` HOT 1
- New Rule: no-render-modifiers
- New lint: potential bug with assigning a value to a tracked property
- new lint: do not use 'this' in tests in gjs/gts files
- New lint: prevent usage of `Input` and `Textarea` (the ember default components) HOT 3
- [email protected] detects single-line components as zero-line components HOT 3
- Parsing error for template tags within classes on v11.11.0 HOT 6
- Drop Recommended Rules for Deprecated Ember 3.x Features HOT 2
- Replace ember-template-imports with content-tag HOT 2
- New rule proposal: require-components-imports-pascal-case HOT 2
- config files in readme should not encourage top level config. overrides only.
- ESLint couldn't find the config "plugin:ember/gts-recommended" to extend from HOT 4
- false positives for `no-unused-vars` in `gjs` files, when using `<Component as |something|>` HOT 3
- gjs/gts Incorrect token mapping after handlebars HOT 1
- Support "Type aware" linting for gts files HOT 13
- "service" import not treated the same as "inject as service" HOT 1
- no-unused-expressions HOT 4
- Plan v13 Release HOT 4
- new "flat" configs contain invalid parser key HOT 19
- `@typescript-eslint` breaks after update to `eslint-plugin-ember` v12 HOT 19
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-ember.