Fetch promises always resolving about ember-fetch HOT 8 CLOSED

fetch by design only rejects if there is a network issue(being offline p.e). You need to check for response.ok to know if the request was successful or not. That is how fetch works.

from ember-fetch.

So even if the site I'm connecting to is offline, it's still a successful promise?

I understand that it doesn't reject on status codes, but not rejecting on network errors is confusing. Thanks anyway!

from ember-fetch.

On network errors it should reject indeed. If it doesn't it's a bug, but this polyfill is so popular that I don't think that's possible. Are you talking about tests?

from ember-fetch.

I've got a fiddle here: https://ember-twiddle.com/625abf7d2eff52a579bf2d82c1eceadc?openFiles=controllers.application.js%2C

I get:

DNS pollyfill: false
DNS fetch: true
SSL pollyfill: false
SSL fetch: true

I am behind a proxy, but still, there seems to be a difference. Can you replicate this?

from ember-fetch.

Using [email protected] results in true for all 4 cases. It appears that this change (10ea9e1) may have introduced it.

from ember-fetch.

Actually I see the error now. I'll see if I can fix it tonight. Essentially we need to return a rejected promise from the second then so we propagate the rejection

from ember-fetch.

Damn. Yes, I need to rethrow. 🤦‍♂️

from ember-fetch.

@rwjblue / @cibernox just a headsup. Master will be a major version bump. So I have created a release-2 branch for all work destined for a 2x release (which this seems part of)

https://github.com/stefanpenner/ember-fetch/commits/release-2

from ember-fetch.