Comments (7)
I'll try to fix this in ember-cli-new-version tomorrow. Thanks for catching this.
from ember-fetch.
This error happens when you have an addon that doesn’t call this._super.included.apply(this, arguments)
and depends on ember-fetch
. We should absolutely handle this situation better though, and error with an actually helpful message.
from ember-fetch.
@initram were you able to figure out which addon was causing you issues?
from ember-fetch.
I was trying to upgrade ember-cli-new-version. But I have more or less given up on that. The tests kept failing due to some timing issues. But I guess the add-on could still add the initialization.
from ember-fetch.
This is not working for me as well, with an engine.
Setup:
my-app
- shared-addon
- ember-fetch
- my-engine
- shared-addon
- ember-fetch
The shared addon does correctly call this._super.included.apply(this, arguments)
.
However, in the treeForVendor
hook,
const preferNative = this.buildConfig.preferNative;
breaks - there is simply no this.buildConfig
. Before that, the included hook is called twice.
Not even manually adding ember-fetch
to the devDependencies of the engine works.
I will try to investigate how this could be fixed...
from ember-fetch.
Seems this issue shouldn't be closed by #172 as people are still having this #200 although it did solve the engine case.
But seems ember-cli-new-version is the addon that didn't call included
hook? @initram can you try patch this addon?
from ember-fetch.
I guess #172 still relies on the included
hook to run!
from ember-fetch.
Related Issues (20)
- Version 6.7.2 onwards seems not to transpile to es5 (Caused IE11 Blank screen, with no console errors) HOT 2
- Could not find module `fetch` imported from `prog/instance-initializers/setup-fetch` HOT 2
- Operation outputFileSync is not allowed to use HOT 15
- Where are all the response headers? HOT 2
- Inconsistent Headers objects with preferNative HOT 1
- fetch is not defined - maybe your browser targets are not covering everything you need HOT 31
- v8.0.3 contains `yarn-error.log` file
- Ember 3.27+ issues deprecation for accessing `window.Ember` HOT 1
- Could not find module `rsvp` imported from `fetch` HOT 6
- Version 8.1.0 not released to NPM? HOT 1
- Migration from jquery.ajax $.ajaxSettings.traditional = true. How remove [] from params
- Dropping Node 10, older versions of Ember
- Archive this repo? HOT 16
- Deprecation warning for assign() from ember/polyfills
- Failed to execute 'fetch' on 'Window': Failed to read the 'signal' property from 'RequestInit': Failed to convert value to 'AbortSignal'.
- ember-polyfills.deprecate-assign deprication in Ember 4.4
- ember-fetch `input` type parameter is incorrect
- Upgrade package "node-fetch" to fix
- `Error: cannot find module rsvp imported from fetch`: Ember 4.12 + embroider-optimized scenario HOT 1
- Maintenance, V2, modern `fetch`, etc
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-fetch.