Code Monkey home page Code Monkey logo

Comments (7)

knownasilya avatar knownasilya commented on August 15, 2024 1

I'll try to fix this in ember-cli-new-version tomorrow. Thanks for catching this.

from ember-fetch.

rwjblue avatar rwjblue commented on August 15, 2024

This error happens when you have an addon that doesn’t call this._super.included.apply(this, arguments) and depends on ember-fetch. We should absolutely handle this situation better though, and error with an actually helpful message.

from ember-fetch.

nlfurniss avatar nlfurniss commented on August 15, 2024

@initram were you able to figure out which addon was causing you issues?

from ember-fetch.

initram avatar initram commented on August 15, 2024

I was trying to upgrade ember-cli-new-version. But I have more or less given up on that. The tests kept failing due to some timing issues. But I guess the add-on could still add the initialization.

from ember-fetch.

mydea avatar mydea commented on August 15, 2024

This is not working for me as well, with an engine.

Setup:

my-app
 - shared-addon
   - ember-fetch
 - my-engine
   - shared-addon
      - ember-fetch

The shared addon does correctly call this._super.included.apply(this, arguments).
However, in the treeForVendor hook,

const preferNative = this.buildConfig.preferNative;

breaks - there is simply no this.buildConfig. Before that, the included hook is called twice.
Not even manually adding ember-fetch to the devDependencies of the engine works.

I will try to investigate how this could be fixed...

from ember-fetch.

xg-wang avatar xg-wang commented on August 15, 2024

Seems this issue shouldn't be closed by #172 as people are still having this #200 although it did solve the engine case.

But seems ember-cli-new-version is the addon that didn't call included hook? @initram can you try patch this addon?

from ember-fetch.

mydea avatar mydea commented on August 15, 2024

I guess #172 still relies on the included hook to run!

from ember-fetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.