Comments (9)
Under repo https://github.com/buschtoens/ember-fetch-sourcemap-bug
rm yarn.lock
yarn install
ember b -prod
No more Building[WARN] (broccoli-uglify-sourcemap) "ember-fetch.map" referenced in "assets/vendor.js" could not be found
from ember-fetch.
The problem was introduced with v4.0.0.
While warning about deprecations, the source map gets built correctly:
yarn add -D 'ember-fetch@<4' && ember build -prod && head -c 500 ./dist/assets/vendor*.map
from ember-fetch.
Which is weird, because according to v3.4.4...v4.0.0
there is no difference between v3.4.5 and v4.0.0. 🤔
from ember-fetch.
Oops, it's not v3.4.4...v4.0.0
. I was tired yesterday, sorry 😄. Looking for the right version now.
from ember-fetch.
It's v4.0.0...v4.0.1
.
Works:
yarn add -D [email protected] && ember build -prod && head -c 500 ./dist/assets/vendor*.map
Breaks:
yarn add -D [email protected] && ember build -prod && head -c 500 ./dist/assets/vendor*.map
Therefore #112 (#111) bricked it. 🙁
from ember-fetch.
Lines 128 to 130 in d25abf6
broccoli-concat
by default creates a source map and injects a sourceMappingURL
comment into the file. When the file is eventually concatenated into vendor.js
, something goes wrong and the sourceMappingURL
is not processed and just stays as it is.
This means that later, when broccoli-uglify-sourcemap
(L31) processes vendor.js
, it finds the rogue sourceMappingURL
comment and tries to load the ember-fetch.map
, which of course at that point is not part of the tree anymore.
One possible fix is passing sourceMapConfig: { enabled: false }
to broccoli-concat
to disable source map generation and thus removing the sourceMappingURL
comment.
from ember-fetch.
I guess the file ends up here and broccoli-concat
itself is probably not aware of source maps when joining files.
So I guess passing sourceMapConfig: { enabled: false }
is indeed the correct solution to this problem.
from ember-fetch.
@stefanpenner @tchak see comment here broccolijs/broccoli-concat#123 (comment)
Any thoughts about this?
from ember-fetch.
So the solution here was to nuke the yarn.lock file? 🤣
from ember-fetch.
Related Issues (20)
- Version 6.7.2 onwards seems not to transpile to es5 (Caused IE11 Blank screen, with no console errors) HOT 2
- Could not find module `fetch` imported from `prog/instance-initializers/setup-fetch` HOT 2
- Operation outputFileSync is not allowed to use HOT 15
- Where are all the response headers? HOT 2
- Inconsistent Headers objects with preferNative HOT 1
- fetch is not defined - maybe your browser targets are not covering everything you need HOT 31
- v8.0.3 contains `yarn-error.log` file
- Ember 3.27+ issues deprecation for accessing `window.Ember` HOT 1
- Could not find module `rsvp` imported from `fetch` HOT 6
- Version 8.1.0 not released to NPM? HOT 1
- Migration from jquery.ajax $.ajaxSettings.traditional = true. How remove [] from params
- Dropping Node 10, older versions of Ember
- Archive this repo? HOT 16
- Deprecation warning for assign() from ember/polyfills
- Failed to execute 'fetch' on 'Window': Failed to read the 'signal' property from 'RequestInit': Failed to convert value to 'AbortSignal'.
- ember-polyfills.deprecate-assign deprication in Ember 4.4
- ember-fetch `input` type parameter is incorrect
- Upgrade package "node-fetch" to fix
- `Error: cannot find module rsvp imported from fetch`: Ember 4.12 + embroider-optimized scenario HOT 1
- Maintenance, V2, modern `fetch`, etc
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-fetch.