ember build --watch fails with '[NodeWrapper:4 /path/to/some/folder] is not a SourceNode' when the app name contains 'ember-data' anywhere about ember-cli HOT 10 OPEN

😫 here's me thinking it's an exact version problem and it's because of the name of the app 😫

I don't know what to do with this issue now 🤔 I would think that we should close it since it's clearly something to do with ember-data's strange build system, but it's a build issue that people will feel with a newly generated app from ember-cli so I kinda want to leave this open 🤔

I suspected it was something to do with rollup because looking at the file it's clearly been put through a rollup process (rollup loves to add _1 to all the imported variables) so it is likely that it's because of ember-data's strange rollup build thingy leaking out 😞

from ember-cli.

I'm not sure I would agree that it's a broccoli issue if it goes away when you remove the ember-data dependency 😂 the fact that broccoli is doing an instance of check just means that it relies on all parts of the app discovering the exact same SourceNodeWrapper class when importing it. It's possible that ember-data's internal rollup is doing something odd and creating a second copy somehow which would then fail the instance of check.

It's true that we could work around this by changing broccoli's implementation to use node.constructor.name to check if the node is a SorceNodeWrapper but that's brittle in a different way

from ember-cli.

Does this happen with ember-cli 5.1?
(Or any versions in between?)

from ember-cli.

oooo intersting... it does not happen in [email protected]:

• EMBER_CLI_PNPM=true npx [email protected] new --pnpm ember-5-1
• ember build --watch
• 🎉

from ember-cli.

I also tested it in [email protected] explicitly and that worked:

• EMBER_CLI_PNPM=true npx [email protected] new --pnpm ember-5-2-0
• cd ember-5-2-0
• ember build --watch
• 🎉 it worked

from ember-cli.

I think it's the same issue as this one: emberjs/data#8606

It seems related to the folder name. If it includes ember-data it throws that error. I haven't looked into it myself, just noticed the folder name also included ember-data in the original post.

from ember-cli.

It seems to be a broccoli issue, actually. This issue was mentioned in the other thread: broccolijs/broccoli#503

Keeping it open for visibility makes sense I think 👍.

from ember-cli.

@mansona EmberData does not do anything custom in its build at this point. My suspicion is broccoli or some associated ember-cli dep has a loose check somewhere that more or less amounts to name.startsWith(addonName)

from ember-cli.

Anyone got a solution or workaround for this? I've created a fork of:

https://www.npmjs.com/package/ember-data-hal-9000

and I'm bumping it to 5.4, but getting the mentioned errors.

Edit: I guess the only workaround is to change the name of the package for my fork...

from ember-cli.

I'm getting a similar problem on non-ember-data-named-projects, like here:
NullVoxPopuli/ember-data-resources#392

both projects are named test-app and test-embroider-app

here is the error, it looks like something has gone wrong with broccoli -- potentially the broccoli deps don't correctly declare peers or something -- gonna try some resolutions/overrides

the SourceNode I'm erroring on is "app" (the app folder!)

from ember-cli.