Overwrite error method? about ember-ajax HOT 8 CLOSED

Right now, the way to do that would probably be overwriting the

import AjaxService from 'ember-ajax/services/ajax';
import { isUnauthorizedError } from 'ember-ajax/errors';

export default AjaxService.extend({
  handleResponse() {
    const result = this._super(...arguments);
    if (isUnauthorizedError(result)) {
      // Do whatever you need to do
    } else {
      return result;
    }
  }
});

So instead of providing specific hooks (which could become kind of messy, given a bunch of possible errors) you can use the single handleResponse hook, check the return type of the original handler, detect the type of error using the provided checking functions (details on isUnauthorizedError can be found here) and then do your custom handling however you want to.

Alternatively, if you want to change how an "unauthorized error" is detected (and maybe try some other logic before deciding to throw an error) you can overwrite the isUnauthorizedError method on the service, which is defined here and used here.

from ember-ajax.

Do you mean for detecting the errors? Or specifying a handler function on a per-error-type (401, 403, etc) basis?

from ember-ajax.

The former is exactly what I was looking for, just didn't realize I had to import the error. (Still getting the hang of es6.)

Thanks @alexlafroscia

from ember-ajax.

No problem! You could also do a simple type check of the result variable, like:

if (result instanceof UnauthorizedError) {
  // ...
}

But then you need to import UnauthorizedError instead. We provide the helper methods for doing this exact kind of thing -- I'm glad that works for you!

from ember-ajax.

I think we should make helpers the recommended way to tests errors because
it will allow us to also check for Ember Data errors.

Taras Mankovski

from ember-ajax.

Yeah, for sure. I was more just pointing out that the UnauthorizedError is a unique type that can be checked that way, too

from ember-ajax.

Hi @alexlafroscia this handleResponse method is very interesting, it would be great if you could add it to the README, this exact example is very helpful.

from ember-ajax.

@urbany Thanks! @taras and I are planning to put together a little documentation site with examples and stuff of these kinds of things, since I want to avoid saturating the README with too much information. I'll make sure that that example ends up in there!

from ember-ajax.