Warn user if improperly calling `.get()` on AjaxService about ember-ajax HOT 3 CLOSED

I've run into that same problem myself, but I'm not sure how exactly to pull that off since technically .get is a valid API, just not for making requests.

We could look at overriding the .get method, checking against a whitelist of valid properties and sending that error if it doesn't match. However, then we have to keep that list up to date and I'm not sure it would play too nicely with the fact that we use an ES6 class under the hood.... So my inclination is that that wouldn't be a good solution.

@taras do you have any suggestions? As much as I think this would be a great thing to have, I'm just not sure how we would do it since .get is Ember's API

from ember-ajax.

@alexlafroscia we could overload get method and check for how many arguments are passed. If we detect that the user is using get as GET then throw a warning into the console. We won't be able to check in situation when someone does this.get('/someResource') but it's better than nothing.

What do you think?

from ember-ajax.

Yeah, that seems like a good compromise. We could even try to catch instances where the parameter to .get starts with a / to attempt warning about that use case as well.

I'm wondering how implementation would go, since the ES6 class is converted into a Mixin and then applied to the Service that way. I'll mess around with it tonight or tomorrow and see what I can do.

Other than the warning, what should the behavior be? Still proxy through to Ember's .get method, or should we actually throw an error to really draw attention to it?

from ember-ajax.