Comments (7)
Yes, that would be great if you had a failing test case over there.
from broccoli-asset-rev.
FYI, the assetMap generated when generateAssetMap: true
looks correct, so this may be an ember-cli issue.
from broccoli-asset-rev.
The same over here :/
from broccoli-asset-rev.
Hi @typeoneerror, any solution or at least workaround regarding this? ;)
I needed for a commercial project, I'm afraid :/
from broccoli-asset-rev.
@bichotll I didn't have any issues with production builds, it was only when I had customHash: null
and generateAssetMap: false
set in development build that it fails like this. So workaround is to just not use customHash at all locally and deal with the hash output on the dist files.
from broccoli-asset-rev.
A failing test case would be really helpful in debugging this!
from broccoli-asset-rev.
I ran into this issue and in the process of trying to create a failing test case realised, for me at least, that's it's actually caused by an open issue on broccoli-asset-rewrite
: ember-cli/broccoli-asset-rewrite#39.
We reference the same relative image URL a few times in our CSS and each of those references appears to be rewritten multiple times, resulting in assets/
appearing in the path multiple times. This only happens when customHash: null
is specified as if the file is fingerprinted then after the first rewrite the path will no longer match the fingerprint regex.
Happy to provide a failing test for the broccoli-asset-rewrite
repo, but believe the test in the proposed PR to fix the issue linked above covers the same scenario.
from broccoli-asset-rev.
Related Issues (20)
- Fingerprint prepend mysteriously added in wrong place in ONE file only HOT 1
- Support adding to the default fingerprinted extensions HOT 2
- Generate CSS/JS file hash after replacing fingerprinted asset paths HOT 12
- Is it possible to generate assetMap.json in development? HOT 1
- Multiple fingerprinted assetMap.json files with v2.6.0 HOT 5
- [Question] How can I use fingerprint for svg file inside my addon? HOT 2
- Breaks when html files don't contain html
- assetMap keys mysteriously also end up fingerprinted HOT 1
- 3.0.0 no tag at GitHub HOT 3
- how to custom sourcemap filename HOT 1
- Dynamically added assets prefix in the image URL - Ember-CLI HOT 2
- Add maintainers
- Dynamic URLs in JS don't get rewritten (rootURL case) HOT 1
- Ability to skip particular references HOT 1
- assetMap.json replacement is wrong HOT 1
- Add asset map to the bundle as a JS module, so that it can be accessed programmatically without extra network requests HOT 1
- Transfer to ember-cli org? HOT 2
- Template Literals + `prepend` doesn't work correctly and results in invalid JS build HOT 1
- release new version with updated deps
- version published to npm (3.0) does not exist in the codebase
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broccoli-asset-rev.