Code Monkey home page Code Monkey logo

Comments (7)

rickharrison avatar rickharrison commented on September 18, 2024 2

Yes, that would be great if you had a failing test case over there.

from broccoli-asset-rev.

typeoneerror avatar typeoneerror commented on September 18, 2024

FYI, the assetMap generated when generateAssetMap: true looks correct, so this may be an ember-cli issue.

from broccoli-asset-rev.

bichotll avatar bichotll commented on September 18, 2024

The same over here :/

from broccoli-asset-rev.

bichotll avatar bichotll commented on September 18, 2024

Hi @typeoneerror, any solution or at least workaround regarding this? ;)

I needed for a commercial project, I'm afraid :/

from broccoli-asset-rev.

typeoneerror avatar typeoneerror commented on September 18, 2024

@bichotll I didn't have any issues with production builds, it was only when I had customHash: null and generateAssetMap: false set in development build that it fails like this. So workaround is to just not use customHash at all locally and deal with the hash output on the dist files.

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on September 18, 2024

A failing test case would be really helpful in debugging this!

from broccoli-asset-rev.

grayt0r avatar grayt0r commented on September 18, 2024

I ran into this issue and in the process of trying to create a failing test case realised, for me at least, that's it's actually caused by an open issue on broccoli-asset-rewrite: ember-cli/broccoli-asset-rewrite#39.

We reference the same relative image URL a few times in our CSS and each of those references appears to be rewritten multiple times, resulting in assets/ appearing in the path multiple times. This only happens when customHash: null is specified as if the file is fingerprinted then after the first rewrite the path will no longer match the fingerprint regex.

Happy to provide a failing test for the broccoli-asset-rewrite repo, but believe the test in the proposed PR to fix the issue linked above covers the same scenario.

from broccoli-asset-rev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.