Comments (20)
Please provide a sample project
from broccoli-asset-rev.
@rickharrison: I'll reference it here as well. James1x0/asset-rev-issue#1
from broccoli-asset-rev.
@rickharrison: Project updated to 0.0.40 and README.md now shows steps to reproduce issue. Hope this helps. I would think that this issue is because broccoli-less-single is dealing with the tree after broccoli-asset-rev.
from broccoli-asset-rev.
I'm experiencing the same issue with file references in scss files. For now, I'm excluding any scss referenced images from being fingerprinted as a workaround.
I am also using ember-cli.
from broccoli-asset-rev.
I'm sorry I haven't been able to fix this yet. I'm currently swamped with work. If you could try debugging it a little on your own and providing some more information, that would be really helpful.
from broccoli-asset-rev.
@rickharrison I hear you there. We are working in a development only enviroment on several projects and won't be need a production build for several weeks. If you haven't fixed it by then, I'll work on a PR.
from broccoli-asset-rev.
If I get some free time I'll spend some of it trying to debug this as well.
My app just went into production, but this is a very minor issue with a simple workaround so not that big of a deal for me.
from broccoli-asset-rev.
OK thanks! :) I'm super booked through the end of August, but I hope to be able to fix it soon after then.
from broccoli-asset-rev.
@rickharrison Would you like push access on the test repo or would you rather fork to confirm?
from broccoli-asset-rev.
I will just fork and clone. Thanks though!
from broccoli-asset-rev.
news ??
from broccoli-asset-rev.
Updated test repo James1x0/asset-rev-issue to demonstrate issue even with css files. This is also specifically an issue with rickharrison/broccoli-asset-rewrite.
from broccoli-asset-rev.
Could you please update to 0.2.0 and let me know if this helps your issue at all?
from broccoli-asset-rev.
👎 Still doesn't rev assets in source.
from broccoli-asset-rev.
I just ran into this with 0.3.0, referenced background-image URL from less file is not updated. Any updates on this issue?
from broccoli-asset-rev.
I am currently scheduling some time for myself to look into this issue the 2nd week of november while I am on vacation. I hope to get it fixed then.
from broccoli-asset-rev.
Please update to 1.0.0 and test it out for me. (This should fix your issue). I apologize about the wait, but I hope that everything is perfect now.
from broccoli-asset-rev.
Updated to 1.0.0 and removed fingerprint excludes - works nicely! Thanks for taking care of this.
from broccoli-asset-rev.
Awesome, glad to hear it. I'm going to close for now. @James1x0 - if it doesn't solve your issue, I will re-open.
from broccoli-asset-rev.
Can't wait to try it out tomorrow. Thanks @rickharrison!
from broccoli-asset-rev.
Related Issues (20)
- Fingerprint prepend mysteriously added in wrong place in ONE file only HOT 1
- Support adding to the default fingerprinted extensions HOT 2
- Generate CSS/JS file hash after replacing fingerprinted asset paths HOT 12
- Is it possible to generate assetMap.json in development? HOT 1
- Multiple fingerprinted assetMap.json files with v2.6.0 HOT 5
- [Question] How can I use fingerprint for svg file inside my addon? HOT 2
- Breaks when html files don't contain html
- assetMap keys mysteriously also end up fingerprinted HOT 1
- 3.0.0 no tag at GitHub HOT 3
- how to custom sourcemap filename HOT 1
- Dynamically added assets prefix in the image URL - Ember-CLI HOT 2
- Add maintainers
- Dynamic URLs in JS don't get rewritten (rootURL case) HOT 1
- Ability to skip particular references HOT 1
- assetMap.json replacement is wrong HOT 1
- Add asset map to the bundle as a JS module, so that it can be accessed programmatically without extra network requests HOT 1
- Transfer to ember-cli org? HOT 2
- Template Literals + `prepend` doesn't work correctly and results in invalid JS build HOT 1
- release new version with updated deps
- version published to npm (3.0) does not exist in the codebase
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from broccoli-asset-rev.