Code Monkey home page Code Monkey logo

Comments (20)

rickharrison avatar rickharrison commented on August 15, 2024

Please provide a sample project

from broccoli-asset-rev.

James1x0 avatar James1x0 commented on August 15, 2024

@rickharrison: I'll reference it here as well. James1x0/asset-rev-issue#1

from broccoli-asset-rev.

James1x0 avatar James1x0 commented on August 15, 2024

@rickharrison: Project updated to 0.0.40 and README.md now shows steps to reproduce issue. Hope this helps. I would think that this issue is because broccoli-less-single is dealing with the tree after broccoli-asset-rev.

from broccoli-asset-rev.

jeffhertzler avatar jeffhertzler commented on August 15, 2024

I'm experiencing the same issue with file references in scss files. For now, I'm excluding any scss referenced images from being fingerprinted as a workaround.

I am also using ember-cli.

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on August 15, 2024

I'm sorry I haven't been able to fix this yet. I'm currently swamped with work. If you could try debugging it a little on your own and providing some more information, that would be really helpful.

from broccoli-asset-rev.

James1x0 avatar James1x0 commented on August 15, 2024

@rickharrison I hear you there. We are working in a development only enviroment on several projects and won't be need a production build for several weeks. If you haven't fixed it by then, I'll work on a PR.

from broccoli-asset-rev.

jeffhertzler avatar jeffhertzler commented on August 15, 2024

If I get some free time I'll spend some of it trying to debug this as well.

My app just went into production, but this is a very minor issue with a simple workaround so not that big of a deal for me.

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on August 15, 2024

OK thanks! :) I'm super booked through the end of August, but I hope to be able to fix it soon after then.

from broccoli-asset-rev.

James1x0 avatar James1x0 commented on August 15, 2024

@rickharrison Would you like push access on the test repo or would you rather fork to confirm?

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on August 15, 2024

I will just fork and clone. Thanks though!

from broccoli-asset-rev.

outaTiME avatar outaTiME commented on August 15, 2024

news ??

from broccoli-asset-rev.

James1x0 avatar James1x0 commented on August 15, 2024

Updated test repo James1x0/asset-rev-issue to demonstrate issue even with css files. This is also specifically an issue with rickharrison/broccoli-asset-rewrite.

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on August 15, 2024

Could you please update to 0.2.0 and let me know if this helps your issue at all?

from broccoli-asset-rev.

James1x0 avatar James1x0 commented on August 15, 2024

👎 Still doesn't rev assets in source.

from broccoli-asset-rev.

digitalbreed avatar digitalbreed commented on August 15, 2024

I just ran into this with 0.3.0, referenced background-image URL from less file is not updated. Any updates on this issue?

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on August 15, 2024

I am currently scheduling some time for myself to look into this issue the 2nd week of november while I am on vacation. I hope to get it fixed then.

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on August 15, 2024

Please update to 1.0.0 and test it out for me. (This should fix your issue). I apologize about the wait, but I hope that everything is perfect now.

from broccoli-asset-rev.

digitalbreed avatar digitalbreed commented on August 15, 2024

Updated to 1.0.0 and removed fingerprint excludes - works nicely! Thanks for taking care of this.

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on August 15, 2024

Awesome, glad to hear it. I'm going to close for now. @James1x0 - if it doesn't solve your issue, I will re-open.

from broccoli-asset-rev.

James1x0 avatar James1x0 commented on August 15, 2024

Can't wait to try it out tomorrow. Thanks @rickharrison!

from broccoli-asset-rev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.