Code Monkey home page Code Monkey logo

Comments (4)

rickharrison avatar rickharrison commented on July 17, 2024

Thanks for finding that. I can add a = to the first part of the regex and a > to the end. Presumably, though I may need to also check for a in case you have a tag like this:

<script src=/assets/app.js data-attribute=foobar></script>

from broccoli-asset-rev.

rlivsey avatar rlivsey commented on July 17, 2024

Yeah that should do the trick in most situations I'd have thought, aside from the usual problems of parsing HTML with regex!

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on July 17, 2024

I might re-factor to only use the regex if you have passed in a prepend path. Otherwise, we can do a straight find and replace. Let me know if you have any other ideas on how to throw a CDN URL in the asset path.

from broccoli-asset-rev.

rickharrison avatar rickharrison commented on July 17, 2024

Also, please let me know if that fixed your issue. I tested a few different combinations of quotes/no-quotes and it works for me.

from broccoli-asset-rev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.