Code Monkey home page Code Monkey logo

Comments (2)

tgolsson avatar tgolsson commented on May 26, 2024

@repi I've solved this type of issue in three different ways depending on the complexity of the bug:

  1. In some cases, I've simply yanked the whole CMakeLists out of the submodule and reseated it in my repository, updating all paths etc. Then I simply include that file, instead of the one in the submodule.

  2. In some cases I've used execute_process to patch the submodule from my parent CMakeLists.txt. Sometimes by simply injecting a patched CMakeLists file, sometimes by using sed to edit the target file in place. This is a bit shit since it dirties the submodule, however.

  3. You can use set_target_properties to append compile flags on a per-target basis, something like set_target_properties(TargetName PROPERTIES COMPILE_FLAGS "-Wno-atomic-implicit-seq-cst"). However, this requires us to list all targets we want to do this for.

I think in this case, number 2 is probably easiest, and 3 most robust.

from physx-rs.

repi avatar repi commented on May 26, 2024

Ah cool. Don't think #2 would work as it modifies the source directory which build.rs files are not allowed to do, cargo publish detects and fails on that.

Option 3 sounds like something it could be possible though, if Nvidia doesn't merge and publish the PR fix in a timely manner

from physx-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.