Comments (3)
- The clippy lints are fixed (no real problem there).
- rustc-hash seems like it's the way to go; I'll switch that out when I get a minute.
- I started adding safety comments, but it's been a second since I looked at this project, and the remaining uncommented unsafe blocks are all accesses to the shared static (which may actually introduce a race condition in async under unlikely use conditions, but are safe without actual concurrency, which I believe means they're safe in dioxus-web and dioxus-desktop?). I'm fairly certain it's a straightforward fix, but I was putting it off until I did some redesign for thread-safety in general.
from dioxus-shareables.
Thanks for getting back to me so quickly. Nice that you realize when one isn't fresh with all the workings, it can be hard to figure out if the use of unsafe
is actually safe. I don't think I mentioned it above, but I expect a lot of churn from dioxus
for some time to come and that will come with crashes, and it would be nice to be able to rule out UB from this package. So if and when you can get to it, great and thanks again. You can close this issue whenever you like.
from dioxus-shareables.
The safety comments are great. Looks much more approachable.
from dioxus-shareables.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dioxus-shareables.