Enhance delete-indentation about php-mode HOT 5 CLOSED

That would be nice to have in php-mode, as I like the idea a lot. However, I do not believe we should explicitly redefine fixup-whitespace. It provides the same behavior for modes besides php-mode, but now we have a potential future problem whenever Emacs changes the default behavior of that function; I honestly don't know how likely that is, but I would still prefer to avoid it. A different approach would be to write the PHP-specific logic for fixup-whitespace into another function and then, inside of php-mode, wrap fixup-whitespace with a call to defadvice that uses our specific logic. I am just brainstorming out-loud, so I have not tested that idea, but something like that would give us a cleaner separation between php-mode and something built into Emacs which other modes rely on.

from php-mode.

Yeah, I see how I could do that. I will get on that. I think we can do post advice that checks for the current mode and then looks at the character at point. if it sees `" \(->\|::\)`` then we can delete the added space.

from php-mode.

Here, I think I have an adequate solution, that can be expanded upon when necessary. Do you think this is something that should be defcustom'd?

from php-mode.

Thanks for providing a patch with tests and everything. It works as advertised for me so I merged it as b764847 so other people can start using it. I think whether or not it should be controlled by defcustom will be determined if anyone raises an issue here with the change. If everyone thinks delete-indentation is just "Doing the Right Thing" then there is no reason to make it customizable.

from php-mode.

Great!

from php-mode.