Automate regression tests using ERT about php-mode HOT 4 CLOSED

Completely agreed. And just to potentially stop anyone for wasting effort, @haxney has already started work on this:

https://github.com/haxney/php-mode/tree/ert-tests

So any additional effort/support should go towards futhering his work on this issue.

from php-mode.

Question: what should the face property of the errored text in issue-9.php be? Right now, I've just checked that it is not font-lock-string-face, but it would be better to check what it should be.

from php-mode.

Personally I feel the best face right now would be font-lock-warning-face. Removing the apostrophe from the string between the HTML tags in issue-9.php makes the entire tag contents use that face. Semantically I don't think it is ideal because the string does not actually constitute a warning---lots of people would love for php-mode to also have great HTML suppor. But for now consistency would be best.

from php-mode.

I think I'll leave it as not font-lock-string-face. It seems that, whatever we might choose for HTML integration, that text would not be font-lock-string-face so negating that would be the safest bet.

from php-mode.