Code Monkey home page Code Monkey logo

Comments (2)

ejmr avatar ejmr commented on July 17, 2024

Thanks for the bug report. The same problem happens on my machine as well (Emacs 24.2.92.1). Commit f40a4b5 fixes it, now in master. I tried to explain in the commit message as best as possible why it was broken and why the fix actually corrects the issue.

Also I have a bad habit of working on bugs and merging patches before I'm totally awake in the morning, so you'll have to overlook some dumb typos and grammar in the commit message, heh.

from php-mode.

NateEag avatar NateEag commented on July 17, 2024

Thanks very much, both for the fix and the detailed explanation.

I had worked out that php-annotations-inside-comment-p would detect a different face than expected for the first chunk of whitespace in a comment; what I hadn't figured out was exactly how that impacted the rest of the function, and thus whether that really was the culprit.

Again, thanks very much.

from php-mode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.