Emacs < 24.3 and cl-lib about php-mode HOT 5 CLOSED

Thanks for finding this and especially for posting a work-around. A cleaner version I think would be to check for the existence of cl-lib, i.e. does the user have Emacs 24.3, and if not fall back on cl. But I am exhausted and about to go sleep so I will write a patch to correct this tomorrow. I really don't understand why Emacs has made these changes to cl and flet and such, but now's not the time or place to get into a rant...

from php-mode.

How about:

(unless (require 'cl-lib nil t)
  (require 'cl))

As far as I know they made the changes to keep the namespace pure. Now they don't (shouldn't?) have to warn about the run-time use of these functions/macros.

from php-mode.

Whaddya know, can't sleep, so still up programming, heh.

Great idea @ryuslash . @targzeta , would you mind trying out the code @ryuslash posted to see if that clears up all of the related byte-compiler warnings for you? If so I will add that as a patch, giving @ryuslash authorship credit of course.

from php-mode.

yes,
the @ryuslash's patch works fine.

--- /tmp/php-mode.el    2012-12-20 10:08:43.000000000 +0100
+++ php-mode.el 2012-12-20 15:05:41.801574000 +0100
@@ -67,7 +67,8 @@
 (require 'custom)
 (require 'flymake)
 (eval-when-compile
-  (require 'cl-lib)
+  (unless (require 'cl-lib nil t)
+  (require 'cl))
   (require 'regexp-opt)
   (defvar c-vsemi-status-unknown-p)
   (defvar syntax-propertize-via-font-lock))

but, is safely to fall back on cl? However, you can patch php-mode and close this issue.

Thanks a lot,
Emanuele

from php-mode.

The patch by @ryuslash is now in the master branch.

...but, is safely to fall back on cl?

Yes, I believe it is. Since php-mode makes use of some code from the cl(-lib) package, and because that package is changing in the latest version of Emacs, I believe this fallback approach is most appropriate. Not everyone will upgrade their version of Emacs right away, so they will continue to get warnings without something like this. And I prefer to treat warnings like errors.

Again, thanks to both of you.

from php-mode.