Indentation of anonymous functions as arguments about php-mode HOT 9 CLOSED

Yes, it is possible to get the first form of indentation. In fact that is what should be the default, which means that is a bug I need to fix. Thanks for bringing this to my attention. I am a little busy with other things but I will make it a point to address this issue this week (along with some other open issues).

from php-mode.

Fantastic. Thanks for the great job maintaining an up-to-date php-mode :)

from php-mode.

I am looking into a more 'proper' way of adding these settings to php-mode without messing up any of the existing indentation rules, but in the mean time you could use this hook:

(add-hook 'php-mode-hook
          (lambda ()
            (c-set-offset 'statement-block-intro '/)
            (c-set-offset 'block-close -100)))

I tried this against some of the files in the tests/ directory to see if it messed up their indentation and things were fine. But something about using a large negative number like that makes me think there is a better solution available, heh.

from php-mode.

Thanks for the hook, but it messed up the indentation of code blocks for me.

Now every code block after "{" are indented at level 0.

  // code at lvl1
  if(x == y) {
// code is now at lvl0 :(
}
  // code is back at lvl1

from php-mode.

Ah, yes, I knew something was going to go wrong with that cheap hack of a hook, lol. I'm looking into a proper solution though while I brush up on the indentation engine of cc-mode, which php-mode uses. I forget how that system works as soon as I'm done working with it every time...

from php-mode.

Nice, no hurry though, as long as we know you know the issue ;)

I really should pick up elisp and start hacking this stuff myself :P

from php-mode.

I'm not trying to toot my own horn, but something that helped me learn a lot about Elisp was to write a major mode from scratch, like https://github.com/ejmr/tup-mode

This is also a good introduction: http://ergoemacs.org/emacs/elisp.html

And of course in Emacs itself you have C-h i m Emacs Lisp Intro.

from php-mode.

Thanks! I think writing an own major mode is a good start. Guess I'll just have to jump into it.

from php-mode.

This is now fixed as of v1.8 by ea5392c.

from php-mode.