Comments (6)
Trust.market told me that they're sending the royalties after testing on their devnet and seen I didn't get the royalties.
They said that only on mainnet they implemented the option.
So I think the royalties are done by the markets, since, the buy/sell are done using their Smart Contract afaik
from elven-nft-minter-sc.
I've spoken with deadrare and they execute a piece of their smart contract that handles trades to send EGLD to the SC's wallet that created the collection. They said they "honor" what Elrond has as the listed royalties so I think it's ultimately up to the exchange or marketplace to implement that functionality. If they didn't, well, we wouldn't list our collection now would we.
I have a production SC that is receiving royalties from sales.
from elven-nft-minter-sc.
I also think it should be implemented by the marketplace only. Still, in the official Elrond repos, there are also methods on minter smart contracts responsible for calling the marketplace and claiming the royalties. I'll go back to it soon and do some more research on that topic.
from elven-nft-minter-sc.
From what I know, the royalties are sent automatically, so it is good. At least projects built using elven tools report that.
Are these only just in case when SC isn't payable?
- https://github.com/ElrondNetwork/elrond-wasm-rs/blob/master/contracts/examples/nft-minter/src/lib.rs#L67
- https://github.com/ElrondNetwork/sc-nft-collection-minter/blob/main/nft-minter/src/nft_marketplace_interactor.rs#L24
from elven-nft-minter-sc.
from the dev telegram group, a message from trust.market.
We don’t send from trust.market (not directly, you have to send us a message to WL your SC after we check is a good one, or you can claim them as above)
(...)
Is for protecting the cross shard txs to non payable SCs where the funds will get lost in the marketplace SC
So I think it will be best to implement something similar to the ones linked above.
Check if it will be possible to test on devnet.trust.market
from elven-nft-minter-sc.
Related Issues (20)
- Make sure that the api's metadata and media are properly generated for the NFT HOT 2
- [already fixed in the development branch] New bug related to the shuffle open endpoint HOT 1
- Remove the gateway entry and leave only the ipfs:// schema based uri HOT 2
- [already fixed in the development branch] Giveaway - Start image filename indexes at 1 instead of 0 HOT 4
- Mint left NFTs HOT 3
- Possibility of minting NFT tokens over limit? HOT 5
- Prepare init for contract upgrade HOT 2
- Token amount checks for giveaway endpoint HOT 4
- Clearing storage when setting new drops is not optimal HOT 2
- Add additional queries HOT 1
- [Docs] on Elven Tools workflows HOT 1
- Check the impact on performance if the initial shuffle is moved to the issue_token callback
- [important] Changes in populateIndexes required soon! HOT 1
- Allow to set up other properties and roles for collection ESDT HOT 1
- Add 'remove address' from allowlist
- Adjust the SC for elrond-wasm 0.29.* HOT 1
- populateIndexes - investigate new ElrondNetwork repos
- Allow spaces for the NFTs tokens names
- Upgrade SC HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elven-nft-minter-sc.