Code Monkey home page Code Monkey logo

Comments (6)

butavpaul avatar butavpaul commented on June 11, 2024

Trust.market told me that they're sending the royalties after testing on their devnet and seen I didn't get the royalties.
They said that only on mainnet they implemented the option.
So I think the royalties are done by the markets, since, the buy/sell are done using their Smart Contract afaik

from elven-nft-minter-sc.

tannerhallman avatar tannerhallman commented on June 11, 2024

I've spoken with deadrare and they execute a piece of their smart contract that handles trades to send EGLD to the SC's wallet that created the collection. They said they "honor" what Elrond has as the listed royalties so I think it's ultimately up to the exchange or marketplace to implement that functionality. If they didn't, well, we wouldn't list our collection now would we.

I have a production SC that is receiving royalties from sales.

from elven-nft-minter-sc.

juliancwirko avatar juliancwirko commented on June 11, 2024

I also think it should be implemented by the marketplace only. Still, in the official Elrond repos, there are also methods on minter smart contracts responsible for calling the marketplace and claiming the royalties. I'll go back to it soon and do some more research on that topic.

from elven-nft-minter-sc.

juliancwirko avatar juliancwirko commented on June 11, 2024

From what I know, the royalties are sent automatically, so it is good. At least projects built using elven tools report that.

Are these only just in case when SC isn't payable?

from elven-nft-minter-sc.

juliancwirko avatar juliancwirko commented on June 11, 2024

from the dev telegram group, a message from trust.market.

We don’t send from trust.market (not directly, you have to send us a message to WL your SC after we check is a good one, or you can claim them as above)
(...)
Is for protecting the cross shard txs to non payable SCs where the funds will get lost in the marketplace SC

So I think it will be best to implement something similar to the ones linked above.

Check if it will be possible to test on devnet.trust.market

from elven-nft-minter-sc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.