[BUG] FailedToConnect activity in SendHttpRequest is not executed about elsa-core HOT 3 CLOSED

Based on the information provided, it seems that you have encountered a known issue with the SendHttpRequest activity in Elsa Workflows where the FailedToConnect and Timeout outcomes are not being properly handled. This issue has been acknowledged in the Elsa community, and a fix has been suggested which involves modifying the SendHttpRequestActivityResolver to ensure that these outcomes yield return their respective activities.

To resolve the issue, you should apply the patch you've mentioned to the SendHttpRequestActivityResolver. This will ensure that the Timeout and FailedToConnect activities are returned and can be executed when the corresponding outcomes occur.

Here's a summary of the steps you should take:

1. Apply the patch to the SendHttpRequestActivityResolver as shown in your diff snippet.
2. Rebuild your application with the patched version of SendHttpRequestActivityResolver.
3. Test the workflow again to ensure that the Fault activity is now triggered when the FailedToConnect outcome occurs.

If you are not comfortable applying the patch yourself or if you encounter any issues, you may want to reach out to the Elsa Workflows community for further assistance or to check if there is an updated version of Elsa that includes the fix for this issue.

Please note that modifying the source code of a library can lead to maintenance challenges, so it's always best to check for official fixes or updates before applying custom patches.

This comment was generated by Glime.

from elsa-core.

Hello,

Thanks for this issue, I think you're right, would you like to create a PR to submit your change ?

from elsa-core.

Took me some time to get around to this, but I finally created the PR.

from elsa-core.