Code Monkey home page Code Monkey logo

Comments (10)

w-lfchen avatar w-lfchen commented on May 23, 2024 1

This line is breaking it or will break in the future. It changes the nixpkgs input of the flake to be in line with the main one your flake depends on. If you remove it, my fork should work just fine.
This breaks my fork as all it does is change this nixpkgs input, which admittedly is a bit suboptimal as it results in you downloading nixpkgs at least twice but it is the easiest solution for the time being, I'll update the fix to point out that overriding the input is something you shouldn't do.
If you leave it in its current state, it could break once pr 289595 makes it into nixos-unstable and you update your lockfile due to the old flake then calling the eww-wayland output with an argument that no longer exists.

from eww.

Cloudef avatar Cloudef commented on May 23, 2024 1

Lemme try, as I just removed it and did not try with it with your recent changes.

from eww.

Cloudef avatar Cloudef commented on May 23, 2024

Sadly even with your branch I seem to get

eww > Eww compiled without wayland support. falling back to X11, eventhough wayland was requested.
failed to open window `bar`

Caused by:
    Failed to get x11 window for gtk window

Maybe you can consider using https://github.com/nix-community/naersk instead of rust-overlay
For now I reverted to d96586c where the flake still works

from eww.

w-lfchen avatar w-lfchen commented on May 23, 2024

For now I reverted to d96586c where the flake still works

It was broken on that commit. @Cloudef Can I get some context from you, especially in regards to how you're importing and using the flake and whether you are changing the nixpkgs input?

I'm currently looking into rewriting the flake as the currently structure is suboptimal and can easily break.
Thank you for the recommendation, I'll consider it, though from a quick glance I'm not sure whether naersk supports rust 1.76.0 which is required and the reason for using the overlay as far as I'm concerned.

from eww.

Cloudef avatar Cloudef commented on May 23, 2024

My flakes are here:
https://github.com/Cloudef/nixos-flake/blob/master/flake.nix#L4-L26
https://github.com/Cloudef/nixos-flake/blob/master/modules/eww.nix

I realized, that the reason why it broke for me, but earlier commit works for me is that because I also actually override rust overlay there, probably to workaround whatever you have been fixing 😓
https://github.com/Cloudef/nixos-flake/blob/master/modules/eww.nix#L44C7-L44C43

from eww.

w-lfchen avatar w-lfchen commented on May 23, 2024

@Cloudef You might want to check out my updated temporary fix, I'd appreciate it if you could comment under the pr whether it works for you (hopefully it does ^^')

from eww.

Cloudef avatar Cloudef commented on May 23, 2024

If you remove it, my fork should work just fine.

Actually I did remove it but it did not work, so that's why I think it might be rust-overlay that eventually breaks it (and that also has nixpkgs follow)

from eww.

w-lfchen avatar w-lfchen commented on May 23, 2024

How does rust overlay break it and does that apply to the current fix as well?

from eww.

Cloudef avatar Cloudef commented on May 23, 2024

It works even with rust-overlay in inputs and override now as well.

from eww.

w-lfchen avatar w-lfchen commented on May 23, 2024

Thank you for testing that, if I'm not mistaken it should work as long as the overlay is able to provide rust 1.76.0 since that is what eww needs

from eww.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.