Consider removing the need for fetch_session/1 or make add fetch_session/2 to be pluggable about plug HOT 7 CLOSED

I'm thinking that removing the need for fetch_session/1 is the way to go. Currently, it isn't intuitive to have to call it manually. I can look at this

from plug.

@nurugger07 let's hold on this though for now. Today you need to fetch everything in plug, so theoretically it makes sense, but it may be confusing in phoenix because developers are both plugging it explicitly and then needing to fetch it. @chrismccord wants to try some approaches on Phoenix, let's see how it goes and act accordingly here. :) Thanks!

from plug.

@josevalim no problem. I was just going to look into for now and see what the repercussions would be. I'll update the docs in Phoenix for now :)

from plug.

Might be useful to make a crazy simple plug :fetch_session, for when
phoenix controllers are all plugs.

On Thu, Jul 10, 2014 at 3:08 PM, Johnny Winn [email protected]
wrote:

@josevalim https://github.com/josevalim no problem. I was just going to
look into for now and see what the repercussions would be. I'll update the
docs in Phoenix for now :)

Reply to this email directly or view it on GitHub
#60 (comment).

from plug.

Exactly @jeregrine ! that's exactly what this bug report is about!

from plug.

Ugh. feel stupid now. :P

On Thu, Jul 10, 2014 at 3:11 PM, José Valim [email protected]
wrote:

Exactly @jeregrine https://github.com/jeregrine ! that's exactly what
this bug report is about!

Reply to this email directly or view it on GitHub
#60 (comment).

from plug.

We should do the same for fetch_params and friends.

from plug.