Add peer to connection struct about plug HOT 8 CLOSED

👍 I need it for this: #18 (comment)

from plug.

FWIW, there was a discussion for implementing this here: #26

from plug.

Just looked through #26, I really don't like converting the IP tuple into a string.

I would add a remote_ip field that contains the peer's ip as a tuple (and can be overwritten by plugs that parse X-Forwarded-For or the PROXY protocol) and I'd add a peer field that is the original peer we get from cowboy.

I can tackle this on Sunday.

from plug.

Should we make those a struct so we get inspect?

from plug.

and other protocols?

from plug.

Like to_string(conn.peer) == "123.123.53.43:482".

from plug.

I think that would be useful, but IMO the IP struct should be in Elixir's stdlib. I'd want it for Ecto, HTTPoison, and even GenTCP too. (Not sure how that would work with Elixir 1.0 being almost here)

from plug.

Ah, but we'd need not only an IP struct but also a Peer one that has IP and Port and maybe even protocol (TCP, UDP, others?). That seems no longer worth it to me.

from plug.