Nx.all_close not working with EXLA about nx HOT 13 CLOSED

Ok, I think we can close this one then. Scholar worked for me once both are on git and updated to latest. :D

from nx.

It works fine standalone, can you minimize the defn example that still reproduces it?

from nx.

You can also try nx/exla main just in case :)

from nx.

You can also try nx/exla main just in case :)

It seems to be working in nx/exla main. I was working in the main of Scholar. Perhaps there is an issue there?

from nx.

Or I didn't get/compile EXLA properly...

from nx.

You can try mix deps.update exla. Currently it's locked at 0.6.3, but maybe 0.6.4 fixed it. Otherwise we need to depend on exla main in mix.exs I guess.

from nx.

@krstopro make sure you use main for both, if using main. If using a package, do mix deps.update nx exla.

from nx.

Upgraded to 0.6.4, didn't resolve it.

from nx.

Nx.all_close/3 is used all over Scholar as it is used to implement assert_all_close which is behind many unit tests.
https://github.com/elixir-nx/scholar/blob/6c609685db1f5808945425468019d993e06597b4/test/support/scholar_case.ex#L16
Which means it's probably me that made an error somewhere...

from nx.

Can you share your mix.lock?

from nx.

Right now it's the same as in main of Scholar
https://github.com/elixir-nx/scholar/blob/main/mix.lock
If I do mix deps.update nx exla unit tests will fail.

from nx.

Yeah, as I said above, you need to swap exla to use github as well, since nx is pointing to github. It just happens that the commit it is currently locked on did not diverge. Btw, why do you need to bump nx?

from nx.

Yeah, as I said above, you need to swap exla to use github as well, since nx is pointing to github. It just happens that the commit it is currently locked on did not diverge. Btw, why do you need to bump nx?

Didn't need to, just copied what you wrote above and forgot to remove nx. 😅

from nx.