Code Monkey home page Code Monkey logo

Comments (2)

uniqueg avatar uniqueg commented on August 17, 2024 1

Thanks for reporting. This issue is due to Funnel, but not proTES, having adopted TES v1.1.0. The library that throws this error is py-tes.

A few points:

  1. Upgrading py-tes to use the v1.1.0 branch should resolve this issue, but it's possible that we might run into other issues. For example, proTES may not forward the ignore_error value.
  2. Alternatively, downgrading Funnel to a version that adopts v1.0.0 should also fix the issue. However, as far as I know, the latest Funnel version addresses a number of issues and is not just an upgrade to TES v1.1.0, so this would rather be a short-term solution.
  3. The best way forward is probably to upgrade the proTES models to properly support v1.1.0, but making sure that it remains backwards-compatible.
  4. Apart from dealing with ignore_error in one way or another, py-tes should not actually throw this error. This is because additionalProperties is not set to false in the TES specs, meaning that returning additional specs is not violating the specs and should not throw an error. We should open an issue about that.

Do you want to take care of these issues, @athith-g? That is:

  • Pick one of solutions 1.-3. to make the immediate problem go away.
  • Open an issue in the py-tes repo to let Liam and Kyle know that they should handle additional properties gracefully.

from protes.

athith-g avatar athith-g commented on August 17, 2024 1

@uniqueg For sure I'll update the proTES models and open up that issue.

from protes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.