Markdown Parser Creates Different Header Links than .com about electronjs.org-old HOT 5 CLOSED

Adding content from an issue opened on atom/electron which shares the same root problem, from @learningjs:

📝

In browser-window doc, the instance method win.close() links to the Event: 'close', but looks like the link is broken.

electron/electron#3127

@learningjs Unfortunately it's a problem with our markdown parser on the website generating different header ids than the ones on the github.com. On github.com the "Event: 'close'" heading gets event-close as its id and so that's what the docs link to. On the Electron website the same header gets turned into event-39-close-39 😦

I'm looking to fix this in the near-ish future.

from electronjs.org-old.

@jlord Thank you, very well explained 😄

from electronjs.org-old.

🔗 I believe this one also falls into this category electron/electron#3693

from electronjs.org-old.

Also, a little update here—it's looking like GitHub Pages will be switching to a different default markdown renderer and I've tested it and it does the same links as .com ✨ so I'm hoping that happens soon and we'll just switch to that. Otherwise I guess I can build locally and push and not use Pages until they ship that update.

from electronjs.org-old.

Fixed in #174 🎉

from electronjs.org-old.