Code Monkey home page Code Monkey logo

Comments (4)

nathansobo avatar nathansobo commented on May 4, 2024 1

We've avoided the jQuery style ambiguous getter/setter throughout the Atom
codebase, for various reasons:

  • It complicates the implementation of getters and setters by making the
    same function serve two roles
  • It consumes the most likely name you would want to use for the actual
    property being set. If I want to have a @badge instance variable, I can't
    because there's already a method named badge.

On Tue, Aug 6, 2013 at 11:30 AM, David Graham [email protected]:

Getters and setters are uncommon in JavaScript. Instead of setBadge and
getBadge, can we have a badge() method that does this?

badge: (text) ->
if text
# set the text
return theBadgeText()

sets the badgedock.badge('42')

gets the badgetext = dock.badge()


Reply to this email directly or view it on GitHubhttps://github.com//issues/46#issuecomment-22200340
.

from electron.

zcbenz avatar zcbenz commented on May 4, 2024

See https://github.com/atom/atom-shell/wiki/app#appdockbouncetype for the new dock API.

from electron.

dgraham avatar dgraham commented on May 4, 2024

Getters and setters are uncommon in JavaScript. Instead of setBadge and getBadge, can we have a badge() method that does this?

badge: (text) ->
  if text
    # set the text
  return theBadgeText()

# sets the badge
dock.badge('42')

# gets the badge
text = dock.badge()

from electron.

probablycorey avatar probablycorey commented on May 4, 2024

We've never adopted the jquery one-function-as-getter-and-setter style in
Atom. We may be breaking JavaScript patterns, but I'd rather keep new API
methods consistent with the old ones. But if you think that is crazy feel
free to school @github/atom.

from electron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.