Code Monkey home page Code Monkey logo

Comments (3)

zcbenz avatar zcbenz commented on May 4, 2024

This exception is mainly implemented in Chromium by trapping the Date.getTime call in unload handler:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/v8/DateExtension.cpp&q=Too%20much%20time%20spent%20in%20unload%20handler&sq=package:chromium&type=cs&l=43

In the case of Atom, Date.getTime is mainly called by jQuery to create event objects, and this exception happens when clearing DOM in the unload handler:
https://github.com/github/atom/blob/master/src/app/window.coffee#L102

The Too much time spent in unload handler error is thrown because jQuery has created more than 1000 event objects (which calls Date.getTime), and it's mainly generated by jQuery.cleanData.

You can do a try/catch in unload handler and print the stack trace to catch it.

Simply do not clean DOM in unload handler would fix this, preventing this exception to occur requires patching Chromium.

from electron.

probablycorey avatar probablycorey commented on May 4, 2024

This is mainly a result of the package config panel. There are ~6 events
created for each package view. This results in a slow shutdown. I tried to
do some clever things by overriding clearData in the config panel's
shutdown, but I think the real solution is to redo how we are displaying
packages and handling package events.

On Tue, Jun 25, 2013 at 7:50 PM, Cheng Zhao [email protected]:

This exception is mainly implemented in Chromium by trapping the
Date.getTime call in unload handler:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/v8/DateExtension.cpp&q=Too%20much%20time%20spent%20in%20unload%20handler&sq=package:chromium&type=cs&l=43

In the case of Atom, Date.getTime is mainly called by jQuery to create
event objects, and this exception happens when clearing DOM in the unloadhandler:
https://github.com/github/atom/blob/master/src/app/window.coffee#L102

The Too much time spent in unload handler error is thrown because jQuery
has created more 1000 event objects (which calls Date.getTime), and it's
mainly generated by jQuery.cleanData.

You can do a try/catch in unload handler and print the stack trace to
catch it.

Simply do not clean DOM in unload handler would fix this, preventing this
exception to occur requires patching Chromium.

β€”
Reply to this email directly or view it on GitHubhttps://github.com//issues/34#issuecomment-20024321
.

from electron.

zcbenz avatar zcbenz commented on May 4, 2024

This exception is now disabled: electron/libchromiumcontent@d241605.

from electron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.