Code Monkey home page Code Monkey logo

Comments (12)

eldur avatar eldur commented on August 21, 2024

Sorry there is no function like this, but if you need such function take a look at GetRevision. This class maps absent revision to an empty article. Hope this helps?

Do you have ideas how to make it easier to use the functionalities?

from jwbf.

lorinczz avatar lorinczz commented on August 21, 2024

Parse the missing field of API result and add exists getter to Article.
Redirect information is available only at prop=info :(

from jwbf.

eldur avatar eldur commented on August 21, 2024

Feels strange to get an article and then check if it is exists. Or?

btw: why do you need to know the difference between an empty or absent article?

from jwbf.

Hunsu avatar Hunsu commented on August 21, 2024

Thanks I will look at it.

I think the library is missing documentation. I was using another library and that library have a function that return all the articles in in given category. It took me a lot of time to figure out how replace this function with this library.

I have also other questions:

  • Why LIMIT is 50. MediaWiki can return up to 5000 results for bots. In the library we can't change it. I have a bot that make changes on articles that are in given category, the category contains more than 100 000 articles. The bot now will make a lot of request to the server.
  • Why are the save, get methods are syncronized? Two threads can save two diffents articles in the same time and this won't lead to any error.
  • Why there are methods that are coded like this:

public foo(Type bar){
...
return bar;
}

from jwbf.

eldur avatar eldur commented on August 21, 2024
  • For the lack of documentation: I'm not very good in writing docs (see #22, #23, ...), but if you are, feel free to help us.
  • For the LIMIT: I've also thought about this. What do you think about to create a new issue about configurable limits?
  • For the other points: You are right, feels strange. Can you give me a hint where your last finding is?

from jwbf.

lorinczz avatar lorinczz commented on August 21, 2024

To be able to use foo(bar) in expressions. Very useful.

from jwbf.

eldur avatar eldur commented on August 21, 2024

do you mean this 😉
https://github.com/eldur/jwbf/search?q=foo

from jwbf.

Hunsu avatar Hunsu commented on August 21, 2024

I mean this function:

public synchronized T getPerformedAction(T answer) {
// TODO transform to throttled
performAction(answer);
return answer;
}

We don't see what the method do. It's the first time I see a method written like this. We don't know what object was changed.

I will try to help when I have time and when I figure out how things work.

from jwbf.

eldur avatar eldur commented on August 21, 2024

At the beginning of this project, immutability wasn't favored as now. So this method mutates the given answer and returns it, so it helps to save lines.

AnyRequest request = ... 
return b.getPerformedAction(request).getWhatever();

vs.

AnyRequest request = ... 
b.performAction(request)
return request.getWhatever();

See: http://en.wikipedia.org/wiki/Fluent_interface

from jwbf.

eldur avatar eldur commented on August 21, 2024

I tend to close this issue, because the question could be answered with

bot.readDataOpt("ArticleName").isPresent()

from jwbf.

Hunsu avatar Hunsu commented on August 21, 2024

Why not create it as a function in MediaWikiBot?

from jwbf.

eldur avatar eldur commented on August 21, 2024

because it could save a request

MediaWikiBot bot = createNewBot();
if (bot.isArticlePresent("ArticleName")) { // first request to API
  doSomenthingWith(bot.readData("ArticleName")); // second request to API
} else {
  // whatever
}

vs.

MediaWikiBot bot = createNewBot();
Optional<SimpleArticle> result = bot.readDataOpt("ArticleName"); // the only request to API
if (result.isPresent()) {
  doSomenthingWith(result);
} else {
  // whatever
}

from jwbf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.