Code Monkey home page Code Monkey logo

Comments (2)

codebrain avatar codebrain commented on July 17, 2024 2

OK, this looks like a limitation in the generator, but one could argue that it is also a quirk in the ECS schema definition.

The tracing root object is described with a prefix: '', the same as the base root object - on inspection these are the only two root objects defined with an empty string prefix.

I think it might make more sense for the schema to represent the trace and transaction object as either child objects on the base root, or to flatten the hierarchy by one level and have both trace and transaction exist as their own root objects. This would at least ensure that the schema is more consistent with itself.

In the meantime I will modify the generator to treat this object as described in the documentation and will raise an issue on the ecs repo.

from ecs-dotnet.

webmat avatar webmat commented on July 17, 2024 1

Ah yeah for simplicity's sake both IDs were added in the same file "tracing", but their key names should actually be "trace.id" and "transaction.id".

Relying on the key flat_name in either the nested or flat representation of ECS yaml files will get you the correct key names for fields (base fields are also quirky that way).

You should not rely on the nesting to construct the key name. Leave that mess to me :-)

Corollary, if you need more precomputed values in either yaml file, please let me know. I'll be happy to add them to the ECS generator :-)

from ecs-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.