Comments (3)
I agree that we should include more descriptive error messages. This will be particularly useful for signaling that the apm-server internal queue is full or that it can't contact the upstream Elasticsearch (or kafka) etc. These will be 5xx responses.
In the apm-server, we'd include the error JSON payload if the agent sent an Accept
header that allows for it (*/*
or application/json
etc.) and just return a plain text error if not.
I like error
instead of message
:
{"error": "foo bar baz"}
When looking at the payload you might not see that the response code is not a 2xx (and as you wrote, curl by default doesn't display the status code), so the error
key instead of the message
key clearly indicates that there was a failure. I don't feel strongly about it though.
from apm-server.
@watson can we agree on the above?
from apm-server.
@roncohen sounds good to me 👍 And good point with using error
instead of message
.
What do you want to do with 404 and 405 responses? Should they have a body at all? If so, I imagine that body should follow the Accept
header as well.
from apm-server.
Related Issues (20)
- Flaky test TestServerElasticsearchOutput
- Enable document-level retries by default
- docs: APM "Personal data" built-in data filter doc needs an update
- monitoring: No monitoring metrics on sourcemap usage
- monitoring: Agentcfg monitoring metric names contain dot
- bug
- docs: broken release notes links
- Self instumentation config mismatch for "api_key" and "secret_token" in libbeat instrumentation
- apm-server exits for unknown reason, logs can see otpl related stack HOT 2
- Benchmarks: Create a guide on how to interpret daily benchmark results
- monitoring: apm-server monitoring metrics maintenance
- Investigate nightly benchmarks 0 events/s issue HOT 1
- docs: apm-server compatibility with L7 load balancers
- Duplicate events in logs-apm.error datastream when log sending is enabled on agents HOT 1
- Monitor panics from managed apm-server deployments
- System memory limit fallback doesn't work as expected when sizing APM Server configs
- Introduce profile-guided optimization to APM Server
- Auth failure when running local Tilt Up
- Repeat benchmarks to update the Performance guide for 8.16
- Make wolfi the default image and drop the ubuntu-based image HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apm-server.