collapse button should be type="button" about jquery-ui-multiselect-widget HOT 6 CLOSED

Seems like it would be a straightforward PR if you want to submit one.

from jquery-ui-multiselect-widget.

nope. I'm not familiar with git/github.

from jquery-ui-multiselect-widget.

from jquery-ui-multiselect-widget.

yeah, 13, because 12 didn't work. I'm not familiar with git - I'm using mercurial all day. With git I always end up with a broken archive.
Do we really need to discuss this? I've given a "patch" and opened a bug report.

Full patch is:
`diff -Naur jquery_multiselect-old.js jquery_multiselect.js
--- jquery_multiselect-old.js 2021-07-14 18:34:49.994292271 +0200
+++ jquery_multiselect.js 2021-07-14 15:58:38.038178751 +0200
@@ -512,7 +512,7 @@
// Build the list section for this optgroup, complete w/ option inputs...
var $collapseButton = !!self.options.groupsCollapsable
? $( document.createElement('button') )

•                                .attr({'title': self.linkInfo.collapse.title})
  

•                                .attr({'title': self.linkInfo.collapse.title,'type': 'button'})
                                 .addClass('ui-state-default ui-corner-all ui-multiselect-collapser')
                                 .html(self.linkInfo.collapse.icon)
                              : null;
  

`

from jquery-ui-multiselect-widget.

A PR would get your issue resolved faster, didn't seem unreasonable given that you already have the change. I don't use this project or jQuery anymore so it'll take me longer to get everything set back up and test the changes on my own.

Since a PR is off the table I'll try and get around to this in the next couple of days when I have time.

from jquery-ui-multiselect-widget.

thank you!

from jquery-ui-multiselect-widget.