Log record "extra" fields are missing when using LogstashFormatter about python-logstash-async HOT 6 CLOSED

Sorry for the late response.

I can't reproduce the described behavior with your example. It results in a message like (stripped unrelated fields for readability):

{
    "message": "some message.",
    "type": "python-logstash",
    "extra": {
        "some": "extra",
        "default": "extra",
    }
}

Which version of the library are you using?

from python-logstash-async.

I'm using python-logstash-async==2.3.0

from python-logstash-async.

I just tried with your code again, except that I replaced the logger with a standard Python logger instance and added the handler via logger.addHandler(logstash_handler) and got the expected result.

Might the loguru package related? I don't what it does.

For reference, here is a full message:

{
       "message" => "some message",
           "pid" => 551789,
         "extra" => {
                     "func_name" => "<module>",
           "interpreter_version" => "3.9.9",
                          "line" => 30,
        "logstash_async_version" => "2.3.0",
                  "process_name" => "MainProcess",
                          "some" => "extra",
                          "path" => "test_issue69.py",
                   "thread_name" => "MainThread",
                       "default" => "extra",
                   "interpreter" => "venv/bin/python",
                   "logger_name" => "root"
    },
          "host" => "redacted",
       "program" => "test_issue69.py",
      "@version" => "1",
    "@timestamp" => 2022-01-09T15:09:46.441Z,
          "port" => 37278,
          "type" => "python-logstash",
         "level" => "INFO",
     "logsource" => "redacted"
}

from python-logstash-async.

It might be related to loguru but as I mentioned I was able to track the problem, it's related to the _get_extra_fields method and after overriding it with the fix, the issue was resolved, is it ok if I'll open a pr for that fix?

from python-logstash-async.

Basically a PR is ok but I would like to understand what's the difference and why it works for me with your example and why not for you.

from python-logstash-async.

Feel free to open a PR if you are still interested in and re-open this one. Until then, I like to close this issue.

from python-logstash-async.