Code Monkey home page Code Monkey logo

Comments (2)

mikesname avatar mikesname commented on June 17, 2024

@bencomp I should note this is pretty serious and could (and indeed, might already) cause major problems with validation. Unfortunately I can't see an easy fix with the current structure of the importers where we create child nodes before their parents; might be worth a chat to discuss approaches.

I can see a few different ways to go, but I think it might be worth consolidating the existing code before trying to implement them.

from ehri-rest.

mikesname avatar mikesname commented on June 17, 2024

Okay I had a go at this but I'm not really happy with the result. The EAD handler now keeps a stack of item identifiers as it traverses the hierarchy. This is then fed to the importer instance (instead of the depth) where it is used to build the eventual path ID (note terminology: identifier=c2, path ID=nl-r1-c1-c2.)

Unfortunately the extraction of meaningful identifiers for each unit isn't really robust enough at the moment, and I think we shouldn't go so far as to generate our own identifiers if there're not provided (this is a good use for preprocessing IMHO.)

from ehri-rest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.