Comments (2)
@bencomp I should note this is pretty serious and could (and indeed, might already) cause major problems with validation. Unfortunately I can't see an easy fix with the current structure of the importers where we create child nodes before their parents; might be worth a chat to discuss approaches.
I can see a few different ways to go, but I think it might be worth consolidating the existing code before trying to implement them.
from ehri-rest.
Okay I had a go at this but I'm not really happy with the result. The EAD handler now keeps a stack of item identifiers as it traverses the hierarchy. This is then fed to the importer instance (instead of the depth) where it is used to build the eventual path ID (note terminology: identifier
=c2
, path ID
=nl-r1-c1-c2
.)
Unfortunately the extraction of meaningful identifiers for each unit isn't really robust enough at the moment, and I think we shouldn't go so far as to generate our own identifiers if there're not provided (this is a good use for preprocessing IMHO.)
from ehri-rest.
Related Issues (20)
- Import and update description: sourceFileId case? HOT 1
- Moving items? HOT 1
- More GraphQL ideas...
- Implement union types for described, description etc
- GraphQL: field for general stats
- Update enunciate/site generation...
- Convert Neo4j procedures to functions
- SKOS Export
- Permission Denied for link deletion...? HOT 1
- Null pointers thrown in ingest if <did> elements are empty...
- Whitespace getting stripped from ingested items
- When "moving" ingested items, endeavour to preserve VC membership...
- Allow EAD default language to be set as an ingest parameter...
- Make SAX import handlers immutable...
- Export copy info in EAD
- Deletion of full collections w/ child items... HOT 1
- Return 410 if an item has been deleted... HOT 1
- ClassCastException w/ multiple <langusage> nodes
- Expose link type in GraphQL...
- Users cannot delete links they have created... HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ehri-rest.