Code Monkey home page Code Monkey logo

Comments (5)

eggyal avatar eggyal commented on July 20, 2024

On the issue of automating PRs for upstream changes, I'm not sure how this can best be done. I opened a couple of questions on StackExchange sites:

Neither have (as yet) received an answer.

Under the Pull Request Refs heading (in chapter 6.3 "GitHub - Maintaining a Project"), the Pro Git book states:

There’s also a refs/pull/#/merge ref on the GitHub side, which represents the commit that would result if you push the “merge” button on the site.

It would be perfect if one could manipulate this ref to reflect the subtree merge... will investigate.

from copse.

eggyal avatar eggyal commented on July 20, 2024

As an aside, since b9c0735 the process for pulling in upstream changes now looks something like this:

splitsh-lite \
    --path=$RUST_REPO \
    --origin=origin/master \
    --prefix=library/alloc/src/collections/btree:collections/btree \
    --prefix=library/alloc/src/testing:testing \
    --target=refs/splits/liballoc/btree

git subtree --prefix=src/liballoc pull $RUST_REPO splits/liballoc/btree

(I'm using splitsh-lite because it maintains a cache rather than having to restart from scratch on every git subtree split—but they should produce the same result).

from copse.

eggyal avatar eggyal commented on July 20, 2024

Unfortunately experimentation with the /refs/pull branch (in #7) was not as successful as hoped: (as suspected) it is read-only on the server and therefore we cannot manipulate it as desired. A PR that requests to merge the imported subtree commit will however automatically be closed if a merge-commit is pushed, and such can be created in a local repo as follows:

git merge -Xsubtree=src/liballoc $REMOTE/refs/pull/#/head

This is good enough.

from copse.

eggyal avatar eggyal commented on July 20, 2024

Automated opening of PRs for upstream commits has been added in 5630744.

Leaving issue open as further CI still required for testing, branch protection etc.

from copse.

eggyal avatar eggyal commented on July 20, 2024

Testing and branch protection added via ba9226c.

from copse.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.