Code Monkey home page Code Monkey logo

Comments (39)

dneykov avatar dneykov commented on May 18, 2024 1

I don't think is normal because I have cluster with about 3k annotations in Africa and 6k in Europe. When I'm slightly changing zoom level these numbers swaps. So it shows 3k in Europe and 6k in Africa which is totally wrong.

UPDATE: This is not happening with version 1.0.7 This occurs after 1.0.8

from cluster.

dneykov avatar dneykov commented on May 18, 2024 1

In #15 the problem is solved with version 1.0.7 as I mentioned above version 1.0.7 works as expected but the versions after that have same problem.

from cluster.

dneykov avatar dneykov commented on May 18, 2024 1

I completely rewrote my mapView(_ mapView: MKMapView, viewFor annotation: MKAnnotation) delegate method and now everything seems to work as expected with manager.clusterPosition = . average and Cluster version 2.1.0

from cluster.

josepfm avatar josepfm commented on May 18, 2024 1

@efremidze You think you could implement some animation for the grouping and ungrouping of the annotations.

Something like they all come together at one point and separate.

It would be incredible and improve the user experience.

from cluster.

efremidze avatar efremidze commented on May 18, 2024

Does it work properly when manager.shouldCenterAlignClusters = false?

from cluster.

IVANKRUPSKI avatar IVANKRUPSKI commented on May 18, 2024

from cluster.

josepfm avatar josepfm commented on May 18, 2024

It happens to me too. It put the group on top of the sea when in reality there is no one there.
Any help?

from cluster.

efremidze avatar efremidze commented on May 18, 2024

The pins shouldn't be centered, only the clusters. Ill take a look. The clusters landing in the sea are normal since it is placing them in the center of quadrants.

from cluster.

josepfm avatar josepfm commented on May 18, 2024

You could modify it so that the clusters are created, not in the center, if not in reference to the last or first of the pins with a bit of deviation, if you want.

I think it would be a good idea.

I have three pins in Spain, and when zooming out, as are the 3 near the coast, place the cluster in the sea.

from cluster.

efremidze avatar efremidze commented on May 18, 2024

In your case I would set manager.shouldCenterAlignClusters = false since it does that exactly.

from cluster.

josepfm avatar josepfm commented on May 18, 2024

With manager.shouldCenterAlignClusters = true, the pins , when zooming out, as are the 3 near the coast, place the cluster in the sea.

Could you tell me how to modify your excellent library so that the tool set is placed in the coordinates of the last or first pin?

from cluster.

efremidze avatar efremidze commented on May 18, 2024

I meant manager.shouldCenterAlignClusters = false should do that. It places the cluster based on the average coordinate. I could use median instead.

from cluster.

josepfm avatar josepfm commented on May 18, 2024

I have a bigger problem

When the change is the location, often do not see the pines if I do not zoom and zoom out, and sometimes even doing so not all are displayed.

Could you help me, please, to solve this?

It is very important for my project.

from cluster.

efremidze avatar efremidze commented on May 18, 2024

Im adding options for displaying clusters (center, first, average), however ur issue is probably unrelated. Please post an example so I can reproduce it.

from cluster.

efremidze avatar efremidze commented on May 18, 2024

I reproduced the bug. I'll try to get to this as soon as possible, but if you have a fix for it, pull-requests are always welcome!

from cluster.

efremidze avatar efremidze commented on May 18, 2024

Fixed in 2.1.0

from cluster.

dneykov avatar dneykov commented on May 18, 2024

I have similar problem with 2.1.0
I have clusters in 2 continents and when I zoom out to see both clusters, cluster counts are changing when when changing zoom levels.

from cluster.

efremidze avatar efremidze commented on May 18, 2024

I don't think thats a bug, its by design.

from cluster.

josepfm avatar josepfm commented on May 18, 2024

Now it works worse.

When I change the location of the map, it does not show me the annotations or the clusters.

When I charge it for the first time either.

I have to be zooming so that they start to see each other.

You could review it?

from cluster.

efremidze avatar efremidze commented on May 18, 2024

@dneykov Ill look into that. Are experiencing the same issue with 2.1.0?
@jose46moreno which version?

from cluster.

efremidze avatar efremidze commented on May 18, 2024

Im testing it and everything appears right. Ill add unit tests. Help is appreciated.

from cluster.

dneykov avatar dneykov commented on May 18, 2024

@efremidze Yes this is the case in 2.1.0 as well
Here are examples on different zoom levels with 2.1.0

screen shot 2017-12-07 at 9 48 02 am copy
screen shot 2017-12-07 at 9 52 10 am copy
screen shot 2017-12-07 at 9 52 27 am copy

from cluster.

efremidze avatar efremidze commented on May 18, 2024

What clusterPosition are you using?

from cluster.

dneykov avatar dneykov commented on May 18, 2024

manager.clusterPosition = .nearCenter

from cluster.

efremidze avatar efremidze commented on May 18, 2024

r u having the same issue when setting clusterPosition to .center or .average?

from cluster.

dneykov avatar dneykov commented on May 18, 2024

@efremidze I have tried . center before but the result is the same. I didn't tried . average but can try it at Monday and will let you know the result.

from cluster.

josepfm avatar josepfm commented on May 18, 2024

@efremidze the version is 2.1.0.

Besides the problem that clusters do not appear at times, it also happens to me as a @dneykov and that is that it moves position clusters when I zoom.

from cluster.

tdimeco avatar tdimeco commented on May 18, 2024

Actually this is an old issue, see #15.

from cluster.

josepfm avatar josepfm commented on May 18, 2024

Help?

from cluster.

efremidze avatar efremidze commented on May 18, 2024

Its not related to #15, that issue related to a meridian bug.

from cluster.

efremidze avatar efremidze commented on May 18, 2024

Can u guys send me a sample project to reproduce?

from cluster.

josepfm avatar josepfm commented on May 18, 2024

@efremidze here I leave a link to my Dropbox folder with the video where you can see the error:

https://www.dropbox.com/sh/exo23lipw6n0hs6/AACALNR29SY7v881CYZjcGRka?dl=0

And an image where I print the number of annotations by console:

captura de pantalla 2017-12-09 a las 10 19 20

Result:

captura de pantalla 2017-12-09 a las 10 18 39

from cluster.

josepfm avatar josepfm commented on May 18, 2024

Here you can see the entire function that runs in the viewWillAppear.

captura de pantalla 2017-12-09 a las 11 21 30

The problem is that when you add the annotations to the manager, it does not call the method ViewFor of MapKit (I have put a print on that method and it does not run)

from cluster.

efremidze avatar efremidze commented on May 18, 2024

I'm unable to reproduce it.
Regarding your setup, mapView.centerCoordinate doesn't call viewFor:, regionDidChangeAnimated: or reload:. Call manager.reload(mapView, visibleMapRect: mapView.visibleMapRect) to reload the map.

from cluster.

IVANKRUPSKI avatar IVANKRUPSKI commented on May 18, 2024

Great!
manager.clusterPosition = .average does the work.

However there again appeared the problem that was described in #49.
Any chances it could be solved?

from cluster.

efremidze avatar efremidze commented on May 18, 2024

Increasing the cell size fixes that issue, however it needs to be done dynamically. I need to investigate a good solution for that.

from cluster.

IVANKRUPSKI avatar IVANKRUPSKI commented on May 18, 2024

Sorry didn't get it. What is meant by the cell size?
This -> manager.maxZoomLevel = 20 ?

from cluster.

efremidze avatar efremidze commented on May 18, 2024

@jose46moreno I'll create a separate issue for that

@IVANKRUPSKI manager.cellSize = 20

from cluster.

IVANKRUPSKI avatar IVANKRUPSKI commented on May 18, 2024

Got it, thanks!

from cluster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.