Code Monkey home page Code Monkey logo

Comments (6)

doasync avatar doasync commented on June 2, 2024

Don't change current signatures, please!

from patronum.

sergeysova avatar sergeysova commented on June 2, 2024

@doasync What the decision?

from patronum.

doasync avatar doasync commented on June 2, 2024

There are still discussions... Maybe it should be used as a separate step (with source + targets) and not return source at all (it may be confusing for some users). I admit that it's convenient for using as a target in sample, but not sure if it's a good practice. Maybe it should be integrated into sample as a part of its functionality.

Let's just leave its current implementation untouched! There are not enough arguments (nor any requests from community) to change its signature for config instead of targets... and the worst part is, it's a breaking change. From a practical standpoint, the current one is better.

from patronum.

sergeysova avatar sergeysova commented on June 2, 2024

@doasync But current implementation will change in #45 . Maybe add support for { source, target } ?

from patronum.

doasync avatar doasync commented on June 2, 2024

@sergeysova I think, we should add a deprecation warning for spread(targets) signature first, and/or introduce this change in major version. spread(source, targets) can cover all needs for now

from patronum.

sergeysova avatar sergeysova commented on June 2, 2024

@doasync We can deprecate it in 0.14.x branch and latest npm-tag.

But in master branch, 0.100+ version, and next npm version release it without previous form.

from patronum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.