Code Monkey home page Code Monkey logo

Comments (4)

IMax153 avatar IMax153 commented on September 15, 2024

I agree with this 100%. I find the existing Effect.filterMap API strange anyways.

from effect.

wbhob avatar wbhob commented on September 15, 2024

Seems like there's a matrix of types in/out that can be built:

boolean OUT Effect<boolean> OUT
Array IN Array.filter Effect.filter
Array<Effect> IN Effect.filterMap & ignore result ?

and a similar one for filter map

T OUT Effect<T> OUT
Array<T> IN Array.filter().map() Effect.filter > Effect.flatMap
Array<Effect<T>> IN Effect.filterMap ?

from effect.

mikearnaldi avatar mikearnaldi commented on September 15, 2024

Wondering if we shouldn't take a different strategy, I currently see a number of issues:

  1. filter can't refine unless for simple scenarios where a Refinement can be supported
  2. filterMap is verbose and requires mixing values with options
  3. filter + filterMap are kind of variants of the same principle and we are duplicating APIs

I have started playing around with the following idea: https://effect.website/play#b7c0272daa18

It looks to me much less verbose and it allows in one shot to both filter/refine and to map

from effect.

mikearnaldi avatar mikearnaldi commented on September 15, 2024

I've placed omit inside the filter function to reduce the noise but it could very well be exported from the main effect module and declared in something like Predicate

from effect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.