Code Monkey home page Code Monkey logo

Comments (3)

datner avatar datner commented on July 18, 2024

when using SST Ion and calling HttpApp.toWebHandler the following error pops
Cannot read properties of undefined (reading 'addEventListener')
It points to request.signal.addEventListener("abort", ...)
the issue is that in aws lambdas the fetch API spec is not complete meaning that the Request is missing AbortController api support, the kind that would give it the .signal property.
Supposedly aws lambda support it in their nodejs 18 lambdas
but according to everyone else besides aws thats not true and you must add /* global fetch */ to the start of the file, but even then it seems that it's not enough and it does not make AbortController and AbortSignal available
There is a suggested polyfill but it won't help us because the the Request is coming straight from the lambda

from effect.

mikearnaldi avatar mikearnaldi commented on July 18, 2024

Well, calling it a platform bug is quite a stretch given it's AWS that is not spec-compliant. BTW make sure comments are not removed in the build pipeline, otherwise /* global fetch */ has no effect

from effect.

datner avatar datner commented on July 18, 2024

@mikearnaldi Ah, I am not the one impacted lol
I think it's a bug because it breaks in /platform, not /platform-node or something.. In general Request is not a platform-agnostic concept. node can't produce a server that speaks in Request and Response for example. It only knows IncomingMessage and OutgoingMessage which also have different semantics (for the node-native http and https they inverse at the boundaries, you send OutgoingMessage and receive it as an IncomingMessage, send back an OutgoingMessage and it arrives as an IncomingMessage), It can be 'fixed' (mitigated) with a simple check for the existence of the signal.
Not fixing this means that even if we were to release a theoretical /platform-aws, it'll be inoperable unless it ships it's own AwsHttpApp.toWebHandler

from effect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.